Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9843003: Proper handling of sequence<T> in IDLs. (Closed)

Created:
8 years, 9 months ago by Anton Muhin
Modified:
8 years, 9 months ago
Reviewers:
podivilov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Proper handling of sequence<T> in IDLs. Committed: https://code.google.com/p/dart/source/detail?r=5833

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M client/dom/scripts/generator.py View 3 chunks +12 lines, -4 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
Anton Muhin
Needed for https://chromiumcodereview.appspot.com/9808037/
8 years, 9 months ago (2012-03-22 22:12:10 UTC) #1
podivilov
http://codereview.chromium.org/9843003/diff/1/client/dom/scripts/generator.py File client/dom/scripts/generator.py (right): http://codereview.chromium.org/9843003/diff/1/client/dom/scripts/generator.py#newcode490 client/dom/scripts/generator.py:490: return 'List<%s>' % DartType(match.group(1)) nit: should be GetIDLTypeInfo(match.group(1)).dart_type() http://codereview.chromium.org/9843003/diff/1/client/dom/scripts/generator.py#newcode551 ...
8 years, 9 months ago (2012-03-23 15:12:07 UTC) #2
Anton Muhin
http://codereview.chromium.org/9843003/diff/1/client/dom/scripts/generator.py File client/dom/scripts/generator.py (right): http://codereview.chromium.org/9843003/diff/1/client/dom/scripts/generator.py#newcode490 client/dom/scripts/generator.py:490: return 'List<%s>' % DartType(match.group(1)) On 2012/03/23 15:12:07, podivilov wrote: ...
8 years, 9 months ago (2012-03-23 17:27:31 UTC) #3
podivilov
8 years, 9 months ago (2012-03-26 09:39:57 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698