Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 9839103: Fix ImpliedInterfaceTest. (Closed)

Created:
8 years, 9 months ago by ahe
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, jat, hausner
Visibility:
Public.

Description

Fix ImpliedInterfaceTest. Committed: https://code.google.com/p/dart/source/detail?r=5880

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M dart/tests/language/language-leg.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/src/ImpliedInterfaceTest.dart View 4 chunks +24 lines, -7 lines 3 comments Download

Messages

Total messages: 7 (0 generated)
ahe
8 years, 9 months ago (2012-03-25 13:29:09 UTC) #1
ahe
https://chromiumcodereview.appspot.com/9839103/diff/1/dart/tests/language/src/ImpliedInterfaceTest.dart File dart/tests/language/src/ImpliedInterfaceTest.dart (left): https://chromiumcodereview.appspot.com/9839103/diff/1/dart/tests/language/src/ImpliedInterfaceTest.dart#oldcode26 dart/tests/language/src/ImpliedInterfaceTest.dart:26: Expect.equals(0, c1.foo); // 01: compile-time error Notice: this was ...
8 years, 9 months ago (2012-03-25 13:31:17 UTC) #2
Lasse Reichstein Nielsen
lgtm
8 years, 9 months ago (2012-03-25 18:15:48 UTC) #3
Lasse Reichstein Nielsen
https://chromiumcodereview.appspot.com/9839103/diff/1/dart/tests/language/src/ImpliedInterfaceTest.dart File dart/tests/language/src/ImpliedInterfaceTest.dart (left): https://chromiumcodereview.appspot.com/9839103/diff/1/dart/tests/language/src/ImpliedInterfaceTest.dart#oldcode26 dart/tests/language/src/ImpliedInterfaceTest.dart:26: Expect.equals(0, c1.foo); // 01: compile-time error Any idea why ...
8 years, 9 months ago (2012-03-25 18:16:46 UTC) #4
kasperl
LGTM. Good catch on the multi-test // versus /// issue.
8 years, 9 months ago (2012-03-26 22:19:09 UTC) #5
ahe
https://chromiumcodereview.appspot.com/9839103/diff/1/dart/tests/language/src/ImpliedInterfaceTest.dart File dart/tests/language/src/ImpliedInterfaceTest.dart (left): https://chromiumcodereview.appspot.com/9839103/diff/1/dart/tests/language/src/ImpliedInterfaceTest.dart#oldcode26 dart/tests/language/src/ImpliedInterfaceTest.dart:26: Expect.equals(0, c1.foo); // 01: compile-time error On 2012/03/25 18:16:46, ...
8 years, 9 months ago (2012-03-27 14:49:42 UTC) #6
gbracha
8 years, 9 months ago (2012-03-28 00:00:33 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698