Issue 9839081: Add test case that ensures that the VM can compile all of the code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9839081: Add test case that ensures that the VM can compile all of the code (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)

Modified:
8 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test case that ensures that the VM can compile all of the code in the dart:io library. Matthias has a changelist out that will make compile_all complaint instead of silently ignoring compilation errors. Once that lands (Monday MTV time) this test will become useful. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5809

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	A	tests/standalone/src/io/CompileAllTest.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/9839081/diff/1/tests/standalone/src/io/CompileAllTest.dart File tests/standalone/src/io/CompileAllTest.dart (right): https://chromiumcodereview.appspot.com/9839081/diff/1/tests/standalone/src/io/CompileAllTest.dart#newcode8 tests/standalone/src/io/CompileAllTest.dart:8: // VMOptions= Do we need ro run this ...

8 years, 9 months ago (2012-03-25 19:50:49 UTC) #2

Mads Ager (google)

8 years, 9 months ago (2012-03-26 02:33:31 UTC) #3

https://chromiumcodereview.appspot.com/9839081/diff/1/tests/standalone/src/io...
File tests/standalone/src/io/CompileAllTest.dart (right):

https://chromiumcodereview.appspot.com/9839081/diff/1/tests/standalone/src/io...
tests/standalone/src/io/CompileAllTest.dart:8: // VMOptions=
On 2012/03/25 19:50:49, Søren Gjesse wrote:
> Do we need ro run this with no options?

No, we don't. Thanks.

Expand Messages | Collapse Messages