Add error handling to random access file

Add error handling to random access file

Now all both sync and async methods on File and RandomAccessFile
should have correct error handling.

Changed readByte and readByteSync to return -1 instead of
reporting an error when end of file is reached. It seems to make
the most sense.

The amount of boiler-plate code in both the native functions and
native port functions in file.cc is growing. Maybe we should
consider some refactoring, e.g. with a table of the expected
argument types for each native port functions together with known
position of the FILE* argument.

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5812

[Mads Ager (google), 2012-03-23 23:17:57]

LGTM! Great to get all this error information propagated to the user!

I agree with your comment. We should attempt to refactor this to get rid of some
of the boilerplate.

https://chromiumcodereview.appspot.com/9839053/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9839053/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:183: _streamErrorHandler = callback;
This looks like a left-over from the previous change.

https://chromiumcodereview.appspot.com/9839053/diff/1/runtime/bin/io.dart
File runtime/bin/io.dart (right):

https://chromiumcodereview.appspot.com/9839053/diff/1/runtime/bin/io.dart#new...
runtime/bin/io.dart:14: #import("dart:builtin");
Remove again before commit.

[Søren Gjesse, 2012-03-26 05:47:40]

http://codereview.chromium.org/9839053/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/9839053/diff/1/runtime/bin/http_impl.dart#newc...
runtime/bin/http_impl.dart:183: _streamErrorHandler = callback;
On 2012/03/23 23:17:57, Mads Ager wrote:
> This looks like a left-over from the previous change.

Yes, the svn rebase was in between the two.

http://codereview.chromium.org/9839053/diff/1/runtime/bin/io.dart
File runtime/bin/io.dart (right):

http://codereview.chromium.org/9839053/diff/1/runtime/bin/io.dart#newcode14
runtime/bin/io.dart:14: #import("dart:builtin");
On 2012/03/23 23:17:57, Mads Ager wrote:
> Remove again before commit.

Sorry, removed - we should have a presubmit check for this :-).