Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 9838017: Make a VM crash more obvious. (Closed)

Created:
8 years, 9 months ago by ahe
Modified:
8 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make a VM crash more obvious. Committed: https://code.google.com/p/dart/source/detail?r=5774

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M dart/tools/test.py View 2 chunks +8 lines, -4 lines 0 comments Download
M dart/tools/utils.py View 1 chunk +13 lines, -0 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 9 months ago (2012-03-22 18:41:47 UTC) #1
ahe
Will print something like: $ ./tools/test.py -mrelease Command: .../dart/tools/testing/bin/macos/dart .../dart/tools/test.dart -mrelease CRASHED with exit code ...
8 years, 9 months ago (2012-03-22 18:42:29 UTC) #2
Emily Fortuna
lgtm, with explanation, please. Sorry this was delayed. For the record, we deleted the out ...
8 years, 9 months ago (2012-03-22 20:40:48 UTC) #3
ahe
https://chromiumcodereview.appspot.com/9838017/diff/1/dart/tools/utils.py File dart/tools/utils.py (right): https://chromiumcodereview.appspot.com/9838017/diff/1/dart/tools/utils.py#newcode269 dart/tools/utils.py:269: return 0x80000000 & exit_code On 2012/03/22 20:40:48, Emily Fortuna ...
8 years, 9 months ago (2012-03-22 20:46:32 UTC) #4
Emily Fortuna
8 years, 9 months ago (2012-03-22 20:47:45 UTC) #5
https://chromiumcodereview.appspot.com/9838017/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

https://chromiumcodereview.appspot.com/9838017/diff/1/dart/tools/utils.py#new...
dart/tools/utils.py:269: return 0x80000000 & exit_code
On 2012/03/22 20:46:32, ahe wrote:
> On 2012/03/22 20:40:48, Emily Fortuna wrote:
> > where's the x8000000 coming from?
> 
> I don't know. All I know is that this is in test.py that is running on all the
> V8 build bots and it seems to work. See
>
http://code.google.com/p/v8/source/browse/branches/bleeding_edge/tools/test.p...

Curious. Sgtm...

Powered by Google App Engine
This is Rietveld 408576698