Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 9837102: Fix build break: (Closed)

Created:
8 years, 9 months ago by siva
Modified:
8 years, 9 months ago
Reviewers:
Søren Gjesse, cshapiro
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix build break when compiling with gcc 4.6: ../runtime/bin/file.cc: In function 'void Builtin_File_Flush(Dart_NativeArguments)': ../runtime/bin/file.cc:356:12: error: variable 'return_value' set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors Committed: https://code.google.com/p/dart/source/detail?r=5923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M bin/file.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 9 months ago (2012-03-28 02:07:09 UTC) #1
cshapiro
lgtm
8 years, 9 months ago (2012-03-28 02:07:37 UTC) #2
Søren Gjesse
8 years, 9 months ago (2012-03-28 06:23:03 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698