Triage co19 tests.

Triage co19 tests.

Committed: https://code.google.com/p/dart/source/detail?r=5780

[ahe, 2012-03-23 13:08:40]

+lrn

[Lasse Reichstein Nielsen, 2012-03-23 13:18:57]

LGTM

https://chromiumcodereview.appspot.com/9837034/diff/1/dart/tests/co19/co19-le...
File dart/tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/9837034/diff/1/dart/tests/co19/co19-le...
dart/tests/co19/co19-leg.status:144: Language/03_Overview/1_Scoping_A02_t07:
Fail # duplicate definition of f(var f){f();}
Please say what our error is. In this case it's probably just "unhandled
duplicate def...", but from just the text it's impossible to see whether we fail
to detect the duplicate definition or if we mistakenly detect it.

[ahe, 2012-03-23 13:24:49]

Thank you, Lasse.

https://chromiumcodereview.appspot.com/9837034/diff/1/dart/tests/co19/co19-le...
File dart/tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/9837034/diff/1/dart/tests/co19/co19-le...
dart/tests/co19/co19-leg.status:144: Language/03_Overview/1_Scoping_A02_t07:
Fail # duplicate definition of f(var f){f();}
On 2012/03/23 13:18:58, Lasse Reichstein Nielsen wrote:
> Please say what our error is. In this case it's probably just "unhandled
> duplicate def...", but from just the text it's impossible to see whether we
fail
> to detect the duplicate definition or if we mistakenly detect it.

That is kind of implicit. I aggressively push all @compile-error to the end of
this file.

The problem is that we don't set up the right scopes and I'll probably do
something about that soon :-)

[ahe, 2012-03-23 14:05:18]

I added a few comments. Hopefully those makes it easier to understand what each
section is about.

[Lasse Reichstein Nielsen, 2012-03-23 14:07:56]

Thanks for the comment :)

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
File dart/tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
dart/tests/co19/co19-leg.status:97: LibTest/core/String/charCodes_A01_t01: Fail,
OK # compiler cancelled: Unhandled non-BMP character: U+10000
Should these be grouped with co19 errors. It's really a leg problem that we
can't handle non-BMP characters.

[ahe, 2012-03-23 14:17:20]

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
File dart/tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
dart/tests/co19/co19-leg.status:97: LibTest/core/String/charCodes_A01_t01: Fail,
OK # compiler cancelled: Unhandled non-BMP character: U+10000
On 2012/03/23 14:07:56, Lasse Reichstein Nielsen wrote:
> Should these be grouped with co19 errors. It's really a leg problem that we
> can't handle non-BMP characters.

So is big int :-)

I'm keeping them here because we aren't sure what we want to do.

My plan is to work with the Unipro team to split these tests so we can pass all
except for tests that must use non-BMP or big int. Most of these tests test much
more than lack of surrogates and use of big int.

Also, I'm deferring a full review of these issues as I expect it will be a
time-consuming task.

[ngeoffray, 2012-03-23 17:05:45]

LGTM

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
File dart/tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
dart/tests/co19/co19-leg.status:44: # langauge specification, co19 test suite,
or add a comment that ahe
langauge -> language

https://chromiumcodereview.appspot.com/9837034/diff/2003/dart/tests/co19/co19...
dart/tests/co19/co19-leg.status:44: # langauge specification, co19 test suite,
or add a comment that ahe
ahe -> ahe@