Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 9835089: Prevent sort on immutable lists. (Closed)

Created:
8 years, 9 months ago by ahe
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, compiler-dev_dartlang.org
Visibility:
Public.

Description

Prevent sort on immutable lists. Committed: https://code.google.com/p/dart/source/detail?r=5828

Patch Set 1 #

Patch Set 2 : Temporary interceptor for copyFrom$4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M dart/frog/leg/lib/js_helper.dart View 1 2 chunks +9 lines, -0 lines 0 comments Download
M dart/tests/corelib/corelib-leg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
@lrn: Let's see if I can confuse you again ;-)
8 years, 9 months ago (2012-03-25 17:38:56 UTC) #1
Lasse Reichstein Nielsen
LGTM
8 years, 9 months ago (2012-03-25 18:09:28 UTC) #2
ngeoffray
LGTM
8 years, 9 months ago (2012-03-25 18:14:10 UTC) #3
ahe
I added a temporary interceptor for copyFrom. Please let me know if you have any ...
8 years, 9 months ago (2012-03-26 12:24:08 UTC) #4
ngeoffray
I very much prefer not adding the interceptor. It's not in the List interface, and ...
8 years, 9 months ago (2012-03-26 12:30:34 UTC) #5
ahe
8 years, 9 months ago (2012-03-26 13:03:19 UTC) #6
On 2012/03/26 12:30:34, ngeoffray wrote:
> I very much prefer not adding the interceptor. It's not in the List interface,
> and I don't think we should add it just because there is a test for it.
> 
> Pushing the others to acknowledge and act on the problem like you do on the
> other CL is the right thing to do, that's why I would wait for that CL to be
> resolved.

I have submitted the change but I'll send out a new CL to make a tweak to the
test that should be less controversial than CL 9839101.

Powered by Google App Engine
This is Rietveld 408576698