Handle implicit closure of toString.

Handle implicit closure of toString.

Committed: https://code.google.com/p/dart/source/detail?r=5820

[Lasse Reichstein Nielsen, 2012-03-25 18:27:33]

LGTM

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1367: // TODO(ahe): We should be able to
automatically generate these.
I like "automatically generate" :)

[ngeoffray, 2012-03-25 18:35:31]

LGTM

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1363: throw UnsupportedOperationException('new
Null()');
Unrelated, but there is a missing 'new' here, I do hope we don't compile this
method.

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1367: // TODO(ahe): We should be able to
automatically generate these.
You can remove the "be able to"

[ahe, 2012-03-25 19:49:53]

Hi Nicolas and Lasse,

Thank you for your comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1363: throw UnsupportedOperationException('new
Null()');
On 2012/03/25 18:35:32, ngeoffray wrote:
> Unrelated, but there is a missing 'new' here, I do hope we don't compile this
> method.

frog/leg/lib/js_helper.dart:1363:11: error: is not an expression
class(UnsupportedOperationException)
    throw UnsupportedOperationException('new Null()');
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1367: // TODO(ahe): We should be able to
automatically generate these.
On 2012/03/25 18:35:32, ngeoffray wrote:
> You can remove the "be able to"

Done.

https://chromiumcodereview.appspot.com/9835088/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1367: // TODO(ahe): We should be able to
automatically generate these.
On 2012/03/25 18:27:33, Lasse Reichstein Nielsen wrote:
> I like "automatically generate" :)

Not sure I understand. Is there something wrong with my wording? Or are you
saying you like the idea?

[ngeoffray, 2012-03-26 08:47:32]

@floitsch: since you wrote the code for handling closures, maybe you have
another opinion. But after reviewing it, I would not be surprised if we come up
with the same conclusion :)

http://codereview.chromium.org/9835088/diff/6001/dart/frog/leg/lib/js_helper....
File dart/frog/leg/lib/js_helper.dart (right):

http://codereview.chromium.org/9835088/diff/6001/dart/frog/leg/lib/js_helper....
dart/frog/leg/lib/js_helper.dart:1367: // TODO(ahe): We should automatically
generate these.
Just talked with Lasse about this. It's not so trivial to automatically generate
those. Right now, we have a very simple scheme to recognize if something must be
intercepted. Doing something more elegant requires either:

a) Build a table before starting compiling that contains all methods that must
be intercepted (eg methods on List,String,num interfaces), or

b) Have a tool that generates the dart file containing the getters.

Since we already write the interceptors, as well as the ones that have default
values, it doesn't seem that bad to manually write a getter just after the
interceptor. It will make things very easy, including optional arguments:

builtin$get$indexOf(receiver) {
 return (value, [int startIndex]) => builtin$indexOf(receiver, value,
startIndex);
}

[ahe, 2012-03-26 09:24:57]

https://chromiumcodereview.appspot.com/9835088/diff/6001/dart/frog/leg/lib/js...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9835088/diff/6001/dart/frog/leg/lib/js...
dart/frog/leg/lib/js_helper.dart:1367: // TODO(ahe): We should automatically
generate these.
On 2012/03/26 08:47:32, ngeoffray wrote:
> Just talked with Lasse about this. It's not so trivial to automatically
generate
> those. Right now, we have a very simple scheme to recognize if something must
be
> intercepted. Doing something more elegant requires either:
> 
> a) Build a table before starting compiling that contains all methods that must
> be intercepted (eg methods on List,String,num interfaces), or
> 
> b) Have a tool that generates the dart file containing the getters.
> 
> Since we already write the interceptors, as well as the ones that have default
> values, it doesn't seem that bad to manually write a getter just after the
> interceptor. It will make things very easy, including optional arguments:
> 
> builtin$get$indexOf(receiver) {
>  return (value, [int startIndex]) => builtin$indexOf(receiver, value,
> startIndex);
> }

I have removed the TODO for now and continued the discussion in a new thread.