Shard tests run by test.dart, so they can be distributed to multiple machines.

Shard tests run by test.dart, so they can be distributed to multiple machines.

This adds the --shards and --shard option.  Shards is the number of shards, and shard is the 1-based index of this shard.


BUG=
TEST=tools/test.py --shards=3 --shard=1

Committed: https://code.google.com/p/dart/source/detail?r=5960

[Bill Hesse, 2012-03-23 22:33:56]

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_options.dart (right):

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_options.dart:154: new Platform().numberOfProcessors(),
Fix this stray indentation.

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:887: * and if there are n shards and we are
shard number i, only the tests at indices equal to
Fix long lines in this function.

[Mads Ager (google), 2012-03-23 23:38:20]

LGTM with a couple of comments and the indentation issues you have pointed out.

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_options.dart (right):

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_options.dart:165: 'The index of this instance when
running in sharded mode',
Maybe we should add an early bailout check somewhere (just before expanding the
configurations maybe) that the value of the shard option is between 1 and the
shards options.

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:249: if (configuration['shards'] > 1) {
You should add a comment about how this works for sharding. No tests are
actually enqueued and when all tests have been listed the doDone function is
called because there are no tests enqueued to run. At that point, all tests are
know and we compute the shard and enqueue the tests for this shard.

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:896: cachedTests = cachedTests.filter((t) =>
++current % n == i - 1);
I would add some parenthesis here to help the reader.

[kasperl, 2012-03-24 15:22:53]

I suggested using a single '--shard 3:5' option to Bill -- rather than having a
shard and a shards option. Don't know what others think of that.

[Bill Hesse, 2012-03-28 22:46:19]

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:249: if (configuration['shards'] > 1) {
On 2012/03/23 23:38:20, Mads Ager wrote:
> You should add a comment about how this works for sharding. No tests are
> actually enqueued and when all tests have been listed the doDone function is
> called because there are no tests enqueued to run. At that point, all tests
are
> know and we compute the shard and enqueue the tests for this shard. 

Done.

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:887: * and if there are n shards and we are
shard number i, only the tests at indices equal to
On 2012/03/23 22:33:56, Bill Hesse wrote:
> Fix long lines in this function.

Done.

https://chromiumcodereview.appspot.com/9834070/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:896: cachedTests = cachedTests.filter((t) =>
++current % n == i - 1);
On 2012/03/23 23:38:20, Mads Ager wrote:
> I would add some parenthesis here to help the reader.

Done.

https://chromiumcodereview.appspot.com/9834070/diff/7001/tools/testing/dart/t...
File tools/testing/dart/test_options.dart (right):

https://chromiumcodereview.appspot.com/9834070/diff/7001/tools/testing/dart/t...
tools/testing/dart/test_options.dart:168: new _TestOptionSpecification(
Since nobody replied to Kasper's suggestion of --shard 4:6, I didn't change the
options.