Issue 9834028: Initial implementation of "Rename Local Variable" refactoring.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12517 lines, -1029 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartVariable.java	View	1 2	1 chunk	+1 line, -0 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.core/META-INF/MANIFEST.MF	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DartRefactoringDescriptorUtil.java	View	1	1 chunk	+713 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.properties	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/RefactoringSignatureDescriptorFactory.java	View	1	1 chunk	+274 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/util/MultiStateCompilationUnitChange.java	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/util/TextEditUtil.java	View	1	5 chunks	+0 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/CompilationUnitChange.java	View	1	5 chunks	+0 lines, -17 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/IDartRefactorings.java	View	1 2	1 chunk	+414 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/UndoCompilationUnitChange.java	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/DartRefactoringContribution.java	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/DartRefactoringDescriptor.java	View	1	1 chunk	+335 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameDartElementDescriptor.java	View	1 2	1 chunk	+541 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/SourceRangeFactory.java	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/dom/ASTNodes.java	View	1	1 chunk	+945 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/dom/LinkedNodeFinder.java	View	1 2	1 chunk	+253 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/Checks.java	View	1 2	13 chunks	+183 lines, -189 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/DartRefactoringArguments.java	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/DartRefactoringDescriptorUtil.java	View	1 2	1 chunk	+253 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/IDartRefactorings.java	View	1 2	1 chunk	+410 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringAvailabilityTester.java	View	1	71 chunks	+155 lines, -155 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringDescriptorComment.java	View	1	1 chunk	+304 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringExecutionStarter.java	View		3 chunks	+18 lines, -26 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/base/DartStringStatusContext.java	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/changes/TextChangeCompatibility.java	View		1 chunk	+92 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/participants/DartProcessors.java	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameAnalyzeUtil.java	View	1	1 chunk	+492 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java	View	1 2	1 chunk	+483 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameModifications.java	View		6 chunks	+16 lines, -33 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/TempOccurrenceAnalyzer.java	View		1 chunk	+119 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IConfirmQuery.java	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgDestination.java	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgDestinationValidator.java	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgPolicy.java	View	1	1 chunk	+128 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/tagging/IDelegateUpdating.java	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/tagging/IQualifiedNameUpdating.java	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/tagging/ITextUpdating.java	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Messages.java	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ResourceUtil.java	View		1 chunk	+59 lines, -0 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java	View	1 2	18 chunks	+62 lines, -127 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/TextChangeManager.java	View		1 chunk	+120 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartElementLabels.java	View	1	10 chunks	+20 lines, -26 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup.java	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RenameAction.java	View	1 2	2 chunks	+3 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/SelectionDispatchAction.java	View	1 2	3 chunks	+1 line, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/actions/ActionUtil.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/actions/WorkbenchRunnableAdapter.java	View	1	3 chunks	+10 lines, -15 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/DelegateUIHelper.java	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringExecutionHelper.java	View	1 2	1 chunk	+232 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java	View		4 chunks	+13 lines, -170 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSavePreferences.java	View		1 chunk	+0 lines, -21 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RenameSupport.java	View	1 2	11 chunks	+126 lines, -135 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/TextInputWizardPage.java	View	1	1 chunk	+187 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/UserInterfaceManager.java	View		1 chunk	+59 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/UserInterfaceStarter.java	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/actions/RenameDartElementAction.java	View	1 2	9 chunks	+31 lines, -39 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInformationPopup.java	View	1 2	1 chunk	+871 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInputWizardPage.java	View	1 2	1 chunk	+340 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameLinkedMode.java	View	1 2	1 chunk	+534 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameLocalVariableWizard.java	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameRefactoringWizard.java	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameUserInterfaceManager.java	View	1 2	1 chunk	+34 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameUserInterfaceStarter.java	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/ReorgMessages.java	View	1 2	1 chunk	+116 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/ReorgMessages.properties	View	1 2	1 chunk	+95 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java	View	1 2	1 chunk	+129 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionCommandHandler.java	View	1 2	1 chunk	+151 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.java	View	1 2	1 chunk	+366 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.properties	View	1 2	1 chunk	+408 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/DartCorrectionAssistant.java	View	1 2	1 chunk	+352 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/DartCorrectionProcessor.java	View	1 2	1 chunk	+546 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/ICommandAccess.java	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickAssistLightBulbUpdater.java	View	1 2	1 chunk	+269 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/proposals/LinkedNamesAssistProposal.java	View	1 2	1 chunk	+269 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/util/ExceptionHandler.java	View	1	2 chunks	+8 lines, -11 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/util/SWTUtil.java	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/util/Strings.java	View	1	10 chunks	+22 lines, -24 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java	View	1	1 chunk	+146 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

messick

Nice to see a lot of progress on renaming! I'm looking forward to being able ...

8 years, 9 months ago (2012-03-23 16:30:12 UTC) #2

scheglov

I've make change to fix problems. No inlike/linked mode yet, will do this in next ...

8 years, 9 months ago (2012-03-23 23:36:28 UTC) #3

I've make change to fix problems.
No inlike/linked mode yet, will do this in next patch in same CL.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:9:
public static String JavaRefactoringDescriptor_no_description;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:11:
public static String JavaRefactoringDescriptor_no_resulting_descriptor;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:13:
public static String JavaRefactoringDescriptor_not_available;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:25:
public static String RenameJavaElementDescriptor_accessor_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:27:
public static String RenameJavaElementDescriptor_delegate_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:29:
public static String RenameJavaElementDescriptor_deprecation_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:31:
public static String RenameJavaElementDescriptor_hierarchical_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:33:
public static String RenameJavaElementDescriptor_no_java_element;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:35:
public static String RenameJavaElementDescriptor_patterns_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:37:
public static String RenameJavaElementDescriptor_patterns_qualified_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:39:
public static String RenameJavaElementDescriptor_project_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:41:
public static String RenameJavaElementDescriptor_qualified_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:43:
public static String RenameJavaElementDescriptor_reference_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:45:
public static String RenameJavaElementDescriptor_similar_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.java:47:
public static String RenameJavaElementDescriptor_textual_constraint;
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.properties
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/DescriptorMessages.properties:12:
JavaRefactoringDescriptor_no_description=Description has not been set.
On 2012/03/23 16:30:13, messick wrote:
> After reading the code I still was not certain whether users would ever see
> these messages. I *think* they are mostly for debugging. If users can ever see
> them then we will need to rewrite them all to be more comprehensible.

This is problem with reusing JDT code.
We don't know for sure what will be ever used until we will do everything.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:20:
public class JavaRefactoringDescriptorUtil {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:22:
private static final String LOWER_CASE_FALSE =
Boolean.FALSE.toString().toLowerCase();
On 2012/03/23 16:30:13, messick wrote:
> Just use "true" and "false" here. Or else get it from the parser's Token
class.
> Token.FALSE_LITERAL.getSyntax()
> But I don't think it hurts to simply embed the string here.
> Depending on Java syntax is not a good idea.

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:30:
* @return a corresponding input handle. Note: if the given project is not the
JavaElement's
On 2012/03/23 16:30:13, messick wrote:
> JavaElement -> element

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:193:
* Retrieves an <code>{@link DartElement}</code> attribute from map.
On 2012/03/23 16:30:13, messick wrote:
> an -> a

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:203:
public static DartElement getJavaElement(Map<String, String> map, String
attribute, String project)
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:221:
public static DartElement getJavaElement(Map<String, String> map, String
attribute,
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:225:
return handleToElement(null, project, handle, false); //TODO: update Javadoc
On 2012/03/23 16:30:13, messick wrote:
> Javadoc -> Dart doc
> Maybe deleting the comment would be better

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:231:
* Retrieves an <code>DartElement[]</code> attribute from map.
On 2012/03/23 16:30:13, messick wrote:
> an -> a

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:246:
public static DartElement[] getJavaElementArray(Map<String, String> map, String
countAttribute,
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:370:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:432:
if (project != null && !"".equals(project)) {
On 2012/03/23 16:30:13, messick wrote:
> !project.isEmpty() is more readable

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:448:
if (project != null && !"".equals(project) && !path.isAbsolute()) {
On 2012/03/23 16:30:13, messick wrote:
> !project.isEmpty() is more readable

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:489:
if (project != null && !"".equals(project) && resourcePath.segmentCount() != 1)
{
On 2012/03/23 16:30:13, messick wrote:
> !project.isEmpty() is more readable

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:555:
*          not the JavaElement's project, then the full handle is stored
On 2012/03/23 16:30:13, messick wrote:
> JavaElement's -> <code>element</code>'s

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:560:
public static void setJavaElement(Map<String, String> arguments, String
attribute,
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/JavaRefactoringDescriptorUtil.java:582:
public static void setJavaElementArray(Map<String, String> arguments, String
countAttribute,
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/RefactoringSignatureDescriptorFactory.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/RefactoringSignatureDescriptorFactory.java:258:
public static RenameJavaElementDescriptor
createRenameJavaElementDescriptor(String id) {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/refactoring/descriptors/RefactoringSignatureDescriptorFactory.java:262:
public static RenameJavaElementDescriptor
createRenameJavaElementDescriptor(String id,
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/IJavaRefactorings.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/IJavaRefactorings.java:10:
* Interface for refactoring ids offered by the JDT tooling.
On 2012/03/23 16:30:13, messick wrote:
> This is not JDT. And it is not DDT, either.

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/IJavaRefactorings.java:27:
* @since 1.1
On 2012/03/23 16:30:13, messick wrote:
> Delete @since

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/IJavaRefactorings.java:31:
public interface IJavaRefactorings {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/IJavaRefactorings.java:41:
public static final String CHANGE_METHOD_SIGNATURE =
"org.eclipse.jdt.ui.change.method.signature"; //$NON-NLS-1$
On 2012/03/23 16:30:13, messick wrote:
> Reminder: All these ID strings need to be converted to
> com.google.dart.tools.ui...

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringContribution.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringContribution.java:13:
* Partial implementation of a Java refactoring contribution.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringContribution.java:18:
* @since 1.1
On 2012/03/23 16:30:13, messick wrote:
> Delete @since everywhere

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringContribution.java:21:
public abstract class JavaRefactoringContribution extends
RefactoringContribution {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:22:
* Partial implementation of a java refactoring descriptor.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:33:
public abstract class JavaRefactoringDescriptor extends RefactoringDescriptor {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:103:
public static final int JAR_MIGRATION = 1 << 16;
On 2012/03/23 16:30:13, messick wrote:
> No jar files in Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:116:
public static final int JAR_REFACTORING = 1 << 19;
On 2012/03/23 16:30:13, messick wrote:
> No jar files in Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:128:
public static final int JAR_SOURCE_ATTACHMENT = 1 << 18;
On 2012/03/23 16:30:13, messick wrote:
> No jar files in Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:145:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:149:
* @return the corresponding java element, or <code>null</code> if no such
element exists
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:156:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:162:
* @return the corresponding java element, or <code>null</code> if no such
element exists
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:170:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:177:
* @return the corresponding java element, or <code>null</code> if no such
element exists
On 2012/03/23 16:30:13, messick wrote:
> Delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:212:
* Creates a new Java refactoring descriptor.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:245:
* {@inheritDoc}
On 2012/03/23 16:30:13, messick wrote:
> Useless comment; delete

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:300:
* capabilities of Java refactorings.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:309:
* @see #JAR_MIGRATION
On 2012/03/23 16:30:13, messick wrote:
> No jar files in Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/JavaRefactoringDescriptor.java:348:
if (description == null || "".equals(description)) {
On 2012/03/23 16:30:13, messick wrote:
> description.isEmpty()

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:30:
public final class RenameJavaElementDescriptor extends JavaRefactoringDescriptor
{
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:54:
private static final String ATTRIBUTE_RENAME_GETTER = "getter"; //$NON-NLS-1$
On 2012/03/23 16:30:13, messick wrote:
> Does renaming of getter and setter in Dart require special handling? We don't
> have to guess which methods are getters and setters, they are identified by
> syntax. I'm guessing these constants won't be used.

I'm not sure if this code like this will be actually used, but what if value is
stored in private field and we rename it?

int _val;
int get val() {return _val;}
int set val(int val) {_val = val;}

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:69:
public static final int STRATEGY_EMBEDDED = 2;
On 2012/03/23 16:30:13, messick wrote:
> We probably won't need the embedded and suffix strategies. Dart is designed to
> have fewer cases where compound names are required. For simplicity let's try
to
> eliminate them and reconsider if that causes too much hardship.

When we rename type JavaElement into DartElement we may be want also rename
javaElement -> dartElement,  javaElements[] -> dartElements[], hasJavaElement()
-> hasDartElement(), etc.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:185:
fRenameGetter = JavaRefactoringDescriptorUtil.getBoolean(fArguments,
ATTRIBUTE_RENAME_GETTER,
On 2012/03/23 16:30:13, messick wrote:
> I think this block should be deleted. The single operation renaming text
matches
> will rename implicit getters and setters. It isn't obvious to me that we want
to
> automatically rename getters and setters identifier by the 'get' and 'set'
> keywords.

See above about private field and similarly named getter/setter.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:203:
fDeprecate = JavaRefactoringDescriptorUtil.getBoolean(fArguments,
ATTRIBUTE_DEPRECATE,
On 2012/03/23 16:30:13, messick wrote:
> Dart does not have a way to identify deprecated elements. It probably never
will
> have delegates. So this block could be deleted.

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:224:
ATTRIBUTE_SIMILAR_DECLARATIONS, fSimilarDeclarations);
On 2012/03/23 16:30:13, messick wrote:
> What does this do?

Rename similarly named variables, field and methods when you rename type.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:250:
public void setDeprecateDelegate(final boolean deprecate) {
On 2012/03/23 16:30:13, messick wrote:
> Is this needed?

No, removed.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:279:
* Sets the Java element to be renamed.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:281:
* Note: If the Java element to be renamed is of type {@link
DartElement#DART_PROJECT}, clients
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:285:
* @param element the Java element to be renamed
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:287:
public void setJavaElement(final DartElement element) {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:293:
* Determines whether the the original Java element should be kept as delegate to
the renamed one.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:295:
* Note: Keeping of original elements as delegates is currently applicable to the
Java elements
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:312:
* Note: Similar declaration updating is currently applicable to Java elements of
type
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:325:
* Sets the new name to rename the Java element to.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:338:
* Note: If the Java element to be renamed is of type {@link
DartElement#DART_PROJECT}, clients
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:354:
* Determines whether getter methods for the Java element should be renamed.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:356:
* Note: Renaming of getter methods is applicable for {@link IField} elements
which do not
On 2012/03/23 16:30:13, messick wrote:
> We don't have IField

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:362:
public void setRenameGetters(final boolean rename) {
On 2012/03/23 16:30:13, messick wrote:
> Consider removing

May be yes, may be no.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:367:
* Determines whether setter methods for the Java element should be renamed.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:369:
* Note: Renaming of setter methods is applicable for {@link IField} elements
which do not
On 2012/03/23 16:30:13, messick wrote:
> We don't have IField

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:375:
public void setRenameSetters(final boolean rename) {
On 2012/03/23 16:30:13, messick wrote:
> Consider removing

May be yes, may be no.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:380:
* Determines whether other Java elements in the hierarchy of the input element
should be renamed
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:389:
public void setUpdateHierarchy(final boolean update) {
On 2012/03/23 16:30:13, messick wrote:
> If this is only valid for IPackageFragment it should be removed (unless it is
> reused for Dart, in which case the comment needs to be updated)

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:394:
* Determines whether qualified names of the Java element should be renamed.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:396:
* Qualified name updating adapts fully qualified names of the Java element to be
renamed in
On 2012/03/23 16:30:13, messick wrote:
> Is "qualified name" expected to refer to library prefixes?

I don't know yet.
I will comment this for now and restore when I will return to this type of
refactoring.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:402:
* {@link IPackageFragment} and {@link IType}. The default is to not rename
qualified names.
On 2012/03/23 16:30:13, messick wrote:
> Delete IPackageFragment

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:412:
* Determines whether references to the Java element should be renamed.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:414:
* Note: Reference updating is currently applicable to all Java element types
except
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:415:
* {@link IPackageFragmentRoot}. The default is to not update references.
On 2012/03/23 16:30:13, messick wrote:
> Delete IPFR

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:425:
* Determines whether similar declarations of the Java element should be updated.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:438:
* Determines whether textual occurrences of the Java element should be renamed.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:440:
* Textual occurrence updating adapts textual occurrences of the Java element to
be renamed in
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:441:
* Java comments and Java strings.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:445:
* {@link IPackageFragment}, {@link IType} and {@link IField}. The default is to
not rename
On 2012/03/23 16:30:13, messick wrote:
> Delete IPF

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:461:
if (fName == null || "".equals(fName)) {
On 2012/03/23 16:30:13, messick wrote:
> Arg! fName.isEmpty()
> (Editorial comment: why did they do it that way?)

isEmpty() = Java 1.6+

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/Checks.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/Checks.java:723:
} else if ("".equals(s)) {
On 2012/03/23 16:30:13, messick wrote:
> Egad! isEmpty()
> 
> BTW I assume all the equals() calls came from someone else's code. If that is
> actually the style you prefer then you can ignore my comments.

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/Checks.java:726:
//workaround for JDK bug (see 26529)
On 2012/03/23 16:30:13, messick wrote:
> Delete bug ref

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/IJavaRefactorings.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/IJavaRefactorings.java:8:
* Interface for refactoring ids offered by the JDT tooling.
On 2012/03/23 16:30:13, messick wrote:
> This is not JDT

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/IJavaRefactorings.java:39:
public static final String CHANGE_METHOD_SIGNATURE =
"org.eclipse.jdt.ui.change.method.signature"; //$NON-NLS-1$
On 2012/03/23 16:30:13, messick wrote:
> Again, these IDs will all be change to dart...

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JDTRefactoringDescriptorComment.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JDTRefactoringDescriptorComment.java:27:
public final class JDTRefactoringDescriptorComment {
On 2012/03/23 16:30:13, messick wrote:
> Delete JDT
> And since

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JDTRefactoringDescriptorComment.java:73:
* Creates a new JDT refactoring descriptor comment.
On 2012/03/23 16:30:13, messick wrote:
> Delete JDT

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringArguments.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringArguments.java:9:
public final class JavaRefactoringArguments {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringArguments.java:18:
* Creates a new java refactoring arguments from arguments
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:19:
public class JavaRefactoringDescriptorUtil {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart
> delete next TODO

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:152:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> delete java

I actually replaced "java" with "Dart" as it is done everywhere else in Editor.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:163:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:178:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:236:
if ("".equals(handle)) {
On 2012/03/23 16:30:13, messick wrote:
> another misspelling of isEmpty

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:243:
if (project != null && !"".equals(project) && !path.isAbsolute()) {
On 2012/03/23 16:30:13, messick wrote:
> and another isEmpty

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:259:
if (project != null && !"".equals(project) &&
project.equals(resource.getProject().getName())) {
On 2012/03/23 16:30:13, messick wrote:
> and another isEmpty

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringAvailabilityTester.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringAvailabilityTester.java:38:
public static DartElement[] getJavaElements(Object[] elements) {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/base/JavaStringStatusContext.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/base/JavaStringStatusContext.java:9:
* A Java string context can be used to annotate a
</code>RefactoringStatusEntry<code>
On 2012/03/23 16:30:13, messick wrote:
> Delete Java everywhere in this comment

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/base/JavaStringStatusContext.java:13:
public class JavaStringStatusContext extends RefactoringStatusContext {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/base/JavaStringStatusContext.java:19:
* Creates a new <code>JavaStringStatusContext</code>.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/base/JavaStringStatusContext.java:34:
* @see RefactoringStatusContext#getCorrespondingElement()
On 2012/03/23 16:30:13, messick wrote:
> delete comment

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/participants/JavaProcessors.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/participants/JavaProcessors.java:14:
* Utility class to deal with Java element processors.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/participants/JavaProcessors.java:16:
public class JavaProcessors {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java:55:
public class RenameLocalVariableProcessor extends DartRenameProcessor implements
IReferenceUpdating {
On 2012/03/23 16:30:13, messick wrote:
> Is this class used to rename parameters? If so, we'll need to handle
parameters
> in Dart doc. And we don't have a parser for Dart doc yet...

Right now I look on this refactoring as refactoring only for local variables.
Not parameters, not globals.

Once I will have at least something, I will at first move all what possible into
Core and write tests.
Then I will extend functionality.
And remove unused methods, fields, classes as long as it does not break tests.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java:351:
// XXX
On 2012/03/23 16:30:13, messick wrote:
> ???

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/TempOccurrenceAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/TempOccurrenceAnalyzer.java:19:
//  private Set<DartIdentifier> fJavadocNodes;
On 2012/03/23 16:30:13, messick wrote:
> See comment in RenameLocalVariableProcessor re: Dart doc

Well, we can not do this right now, so this functionality is commented out.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgPolicy.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgPolicy.java:72:
* @return the destination of this reorg or null if not a java element
On 2012/03/23 16:30:13, messick wrote:
> a java -> an

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgPolicy.java:74:
public DartElement getJavaElementDestination();
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgPolicy.java:77:
* @return the source java elements to reorg
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgPolicy.java:79:
public DartElement[] getJavaElements();
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java:3:
public interface IReorgQueries {
On 2012/03/23 16:30:13, messick wrote:
> BTW we omitted the initial 'I' from most (not all) interface names

May be later?
More we will rename now, more work later to adapt JDT code.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java:5:
public static final int CONFIRM_DELETE_EMPTY_CUS = 2;
On 2012/03/23 16:30:13, messick wrote:
> These constants look like they should be an enum

Again, I'd like to do this later.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/tagging/IQualifiedNameUpdating.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/tagging/IQualifiedNameUpdating.java:25:
* used to inform the refactoring object whether references in non Java files
should be updated.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Messages.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Messages.java:8:
public class Messages {
On 2012/03/23 16:30:13, messick wrote:
> Try to use com.google.dart.tools.ui.Messages instead of creating yet another
> duplicate.

I agree that it would be good to use some shared functionality, but not this
Messages class as you pointed, because it has binding to some *.properties file
and we actually don't want it. So, may be some Strings or something like this.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ResourceUtil.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ResourceUtil.java:13:
public class ResourceUtil {
On 2012/03/23 16:30:13, messick wrote:
> I think these methods belong in
> com.google.dart.tools.core.internal.util.ResourceUtil. It is internal to core.
> Talk to Brian about increasing its visibility.

Can we do this next CL?
I'd like next try to move as much as possible into Core, so visibility change
may be not required at all.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:35:
private static final String JAVA_ELEMENT_DELIMITERS =
TextProcessor.getDefaultDelimiters()
On 2012/03/23 16:30:13, messick wrote:
> JAVA -> DART

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:46:
* @param project the java project from which to get the formatter preferences,
or
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:100:
* @param project the java project from which to get the formatter preferences,
or
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:146:
* Returns <code>true</code> if the given string only consists of white spaces
according to Java.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:159:
if (!Character.isWhitespace(s.charAt(i))) {
On 2012/03/23 16:30:13, messick wrote:
> I dislike this dependency on Java syntax. Since Dart doesn't have Character,
and
> our scanner doesn't have a public API for whitespace testing we have to live
> with it.

Well, this is implementation detail and most probably will not cause any
problems.

Do you want to use UCharacter or com.google.common.base.CharMatcher.WHITESPACE ?

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:209:
* @param project the java project from which to get the formatter preferences,
or
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:252:
public static String markJavaElementLabelLTR(String string) {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:518:
* @param project the java project from which to get the formatter preferences,
or
On 2012/03/23 16:30:13, messick wrote:
> delete java

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/DelegateUIHelper.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/DelegateUIHelper.java:17:
* @since 3.2
On 2012/03/23 16:30:13, messick wrote:
> delete since

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/DelegateUIHelper.java:19:
public class DelegateUIHelper {
On 2012/03/23 16:30:13, messick wrote:
> What's the purpose of this class? We don't have delegates.

This is delegate in Java terms.
I.e. when you rename some method, you leave existing method, but it instead call
(delegates) to the new method.
So, clients of your class will continue to work.

If we don't want to provide such functionality in Dart, we can remove it.
Do we?

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/QualifiedNameComponent.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/QualifiedNameComponent.java:30:
label.setText(RefactoringMessages.QualifiedNameComponent_patterns_label);
On 2012/03/23 16:30:13, messick wrote:
> I think we want to change the label string so that it says something about
> library prefixes instead of qualified names, since Dart doesn't have any
> qualified names other than library prefixes.

I will remove this Class and references on it for now.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/TextInputWizardPage.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/TextInputWizardPage.java:16:
* field and validate its contents. The text is assumed to be a java identifier,
hence CamelCase
On 2012/03/23 16:30:13, messick wrote:
> java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/TextInputWizardPage.java:68:
* (non-Javadoc) Method declared in WizardPage
On 2012/03/23 16:30:13, messick wrote:
> delete comment

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInputWizardPage.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInputWizardPage.java:27:
abstract class RenameInputWizardPage extends TextInputWizardPage {
On 2012/03/23 16:30:13, messick wrote:
> For local variables, we should not be using this wizard. Those names should be
> edited in-place.

Well, in Java if you configure it for inline rename, you can press Rename hotkey
second time and it will open wizard.
So, we may be want both.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInputWizardPage.java:101:
addOptionalLeaveDelegateCheckbox(composite, layouter);
On 2012/03/23 16:30:13, messick wrote:
> Do we need these two delegate items?

Delegate - may be.
Deprecation - definitely no.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameRefactoringWizard.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameRefactoringWizard.java:48:
public static final String PACKAGE_RENAME_SUBPACKAGES = "renameSubpackages";
//$NON-NLS-1$
On 2012/03/23 16:30:13, messick wrote:
> Unneeded

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:48:
/**
On 2012/03/23 16:30:13, messick wrote:
> Editorial comment: This method is ridiculous. It makes no sense to turn Dart
> code from left-to-right into right-to-left, even partially (as this does).

Agree.
I've removed RTL methods from String and their usage here.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:49:
* Returns a label for Java code snippet used in a label. Example is 'Test test=
new Test<?
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart, space before =

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:52:
* @param string the Java code snippet
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:53:
* @return the label for the Java code snippet
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:55:
public static String getJavaCodeString(String string) {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:60:
* Returns a label for Java element name. Example is 'new Test<? extends List>()
{ ...}'. This
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:61:
* method should only be used for simple element names. Use {@link
JavaElementLabels} to create a
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart ?

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:62:
* label from a Java element or {@link BindingLabelProvider} for labels of
bindings.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:64:
* @param name the Java element name.
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:65:
* @return the label for the Java element
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/viewsupport/BasicElementLabels.java:67:
public static String getJavaElementName(String name) {
On 2012/03/23 16:30:13, messick wrote:
> Java -> Dart

Done.

messick

Thanks! This is getting close. Looking forward to that final piece, the in-line rename support. ...

8 years, 9 months ago (2012-03-24 02:33:47 UTC) #4

Thanks! This is getting close.

Looking forward to that final piece, the in-line rename support.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:54:
private static final String ATTRIBUTE_RENAME_GETTER = "getter"; //$NON-NLS-1$
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > Does renaming of getter and setter in Dart require special handling? We
don't
> > have to guess which methods are getters and setters, they are identified by
> > syntax. I'm guessing these constants won't be used.
> 
> I'm not sure if this code like this will be actually used, but what if value
is
> stored in private field and we rename it?
> 
> int _val;
> int get val() {return _val;}
> int set val(int val) {_val = val;}

In that case you'd just make val a public field and omit the getter and setter.
We want to encourage that. Having a private field and a public getter (but not
setter) is perfectly valid. But even then, renaming the getters will be done in
separate operations. We want to keep the Dart Editor UI lean. We can add
advanced features as the language matures but we should start simply.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:69:
public static final int STRATEGY_EMBEDDED = 2;
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > We probably won't need the embedded and suffix strategies. Dart is designed
to
> > have fewer cases where compound names are required. For simplicity let's try
> to
> > eliminate them and reconsider if that causes too much hardship.
> 
> When we rename type JavaElement into DartElement we may be want also rename
> javaElement -> dartElement,  javaElements[] -> dartElements[],
hasJavaElement()
> -> hasDartElement(), etc.

Again, those should be separate operations. If needed as the language matures we
can add support for renaming similar names, but it should not be in v1.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:185:
fRenameGetter = JavaRefactoringDescriptorUtil.getBoolean(fArguments,
ATTRIBUTE_RENAME_GETTER,
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > I think this block should be deleted. The single operation renaming text
> matches
> > will rename implicit getters and setters. It isn't obvious to me that we
want
> to
> > automatically rename getters and setters identifier by the 'get' and 'set'
> > keywords.
> 
> See above about private field and similarly named getter/setter.

Let's keep the UI simple until we know we need more complexity.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:224:
ATTRIBUTE_SIMILAR_DECLARATIONS, fSimilarDeclarations);
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > What does this do?
> 
> Rename similarly named variables, field and methods when you rename type.

Dart Editor is not an IDE. We won't want to do that automatically in v1.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/refactoring/descriptors/RenameJavaElementDescriptor.java:461:
if (fName == null || "".equals(fName)) {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > Arg! fName.isEmpty()
> > (Editorial comment: why did they do it that way?)
> 
> isEmpty() = Java 1.6+

Even then, s.length() == 0 is more readable :)

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/JavaRefactoringDescriptorUtil.java:152:
* Converts an input handle back to the corresponding java element.
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > delete java
> 
> I actually replaced "java" with "Dart" as it is done everywhere else in
Editor.

That's fine, but I deleted java in many places following the same rule I used
here.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java:55:
public class RenameLocalVariableProcessor extends DartRenameProcessor implements
IReferenceUpdating {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > Is this class used to rename parameters? If so, we'll need to handle
> parameters
> > in Dart doc. And we don't have a parser for Dart doc yet...
> 
> Right now I look on this refactoring as refactoring only for local variables.
> Not parameters, not globals.
> 
> Once I will have at least something, I will at first move all what possible
into
> Core and write tests.
> Then I will extend functionality.
> And remove unused methods, fields, classes as long as it does not break tests.

Sounds like a good plan.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java:3:
public interface IReorgQueries {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > BTW we omitted the initial 'I' from most (not all) interface names
> 
> May be later?
> More we will rename now, more work later to adapt JDT code.

Later is fine. We still have a few I-prefixed interfaces.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/reorg/IReorgQueries.java:5:
public static final int CONFIRM_DELETE_EMPTY_CUS = 2;
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > These constants look like they should be an enum
> 
> Again, I'd like to do this later.

That's fine.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ResourceUtil.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ResourceUtil.java:13:
public class ResourceUtil {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > I think these methods belong in
> > com.google.dart.tools.core.internal.util.ResourceUtil. It is internal to
core.
> > Talk to Brian about increasing its visibility.
> 
> Can we do this next CL?
> I'd like next try to move as much as possible into Core, so visibility change
> may be not required at all.

Later is fine.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/Strings.java:159:
if (!Character.isWhitespace(s.charAt(i))) {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > I dislike this dependency on Java syntax. Since Dart doesn't have Character,
> and
> > our scanner doesn't have a public API for whitespace testing we have to live
> > with it.
> 
> Well, this is implementation detail and most probably will not cause any
> problems.
> 
> Do you want to use UCharacter or com.google.common.base.CharMatcher.WHITESPACE
?

No need to change it. I shouldn't have made any comment.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/DelegateUIHelper.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/DelegateUIHelper.java:19:
public class DelegateUIHelper {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > What's the purpose of this class? We don't have delegates.
> 
> This is delegate in Java terms.
> I.e. when you rename some method, you leave existing method, but it instead
call
> (delegates) to the new method.
> So, clients of your class will continue to work.
> 
> If we don't want to provide such functionality in Dart, we can remove it.
> Do we?

We do not want it in v1.

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInputWizardPage.java
(right):

https://chromiumcodereview.appspot.com/9834028/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameInputWizardPage.java:27:
abstract class RenameInputWizardPage extends TextInputWizardPage {
On 2012/03/23 23:36:28, scheglov wrote:
> On 2012/03/23 16:30:13, messick wrote:
> > For local variables, we should not be using this wizard. Those names should
be
> > edited in-place.
> 
> Well, in Java if you configure it for inline rename, you can press Rename
hotkey
> second time and it will open wizard.
> So, we may be want both.

We want everything in the editor to be discoverable. That isn't. That's modal,
and most UI designers consider modal UI to a bad thing. If we need to have a
wizard (and we do not, for locals) we will have to find another way to open it.

FWIW: I don't configure eclipse to do in-line rename. It just comes that way.

messick

8 years, 9 months ago (2012-03-26 18:12:28 UTC) #5

LGTM!

I recommend moving the AST visitor change into a separate CL and getting Brian
and zundel to review it.

http://codereview.chromium.org/9834028/diff/2005/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/ast/DartVariable.java (right):

http://codereview.chromium.org/9834028/diff/2005/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/ast/DartVariable.java:44:
getName().accept(visitor);
This change should have been made long ago.
We have a lot of code that works around its absence.

Expand Messages | Collapse Messages