Add "mock" compilation feature to dart2js and use it to improve test coverage.

Add "mock" compilation feature to dart2js and use it to improve test coverage.

Committed: https://code.google.com/p/dart/source/detail?r=5743

[ngeoffray, 2012-03-22 07:54:03]

LGTM!

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/client/tests/clien...
File dart/client/tests/client/client-leg.status (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/client/tests/clien...
dart/client/tests/client/client-leg.status:6: dom/DOMIsolatesTest: Fail # error:
cannot resolve spawnDomIsolate
You can merge this line and lines 24/25.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/api.dart
File dart/frog/leg/api.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/api.dart#...
dart/frog/leg/api.dart:43: [List<String> options]) {
If you're making it optional, I suggest adding a default value const <String>[],
to partially protect from null.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/emitter.dart
File dart/frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/emitter.d...
dart/frog/leg/emitter.dart:697: if (!compiler.isMockCompilation) {
I would remove this check and the one line 656, to only have one check before
emitting main (line 691).

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/lib/mock....
File dart/frog/leg/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/lib/mock....
dart/frog/leg/lib/mock.dart:29: interface ByteArray extends List default
_InternalByteArray {
Souldn't that be in some mock io library?

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/scripts/build...
File dart/frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/scripts/build...
dart/frog/scripts/buildbot_annotated_steps.py:183: TestStep('browser', mode,
system, 'legium', [], flags)
I guess this run the default suite of tests. Thank you!

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/samples/tests/samp...
File dart/samples/tests/samples/samples-leg.status (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/samples/tests/samp...
dart/samples/tests/samples/samples-leg.status:1: # Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
I think the legium component is in samples.status file, and you need to update
the expectations for it also. I think it should be a matter of adding legium in
this file line 6.

[ahe, 2012-03-22 09:59:39]

Hi Nicolas,

Thank you for your suggestions. I have uploaded a new version with suggested
changes and plan to submit it once I have resolved any merge conflicts and made
sure the tests pass.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/client/tests/clien...
File dart/client/tests/client/client-leg.status (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/client/tests/clien...
dart/client/tests/client/client-leg.status:6: dom/DOMIsolatesTest: Fail # error:
cannot resolve spawnDomIsolate
On 2012/03/22 07:54:03, ngeoffray wrote:
> You can merge this line and lines 24/25.

Done.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/api.dart
File dart/frog/leg/api.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/api.dart#...
dart/frog/leg/api.dart:43: [List<String> options]) {
On 2012/03/22 07:54:03, ngeoffray wrote:
> If you're making it optional, I suggest adding a default value const
<String>[],
> to partially protect from null.

Good catch. Done.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/emitter.dart
File dart/frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/emitter.d...
dart/frog/leg/emitter.dart:697: if (!compiler.isMockCompilation) {
On 2012/03/22 07:54:03, ngeoffray wrote:
> I would remove this check and the one line 656, to only have one check before
> emitting main (line 691).

Done.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/lib/mock....
File dart/frog/leg/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/leg/lib/mock....
dart/frog/leg/lib/mock.dart:29: interface ByteArray extends List default
_InternalByteArray {
On 2012/03/22 07:54:03, ngeoffray wrote:
> Souldn't that be in some mock io library?

I agree, but that is not where the VM team has put ByteArray. I'll add a TODO.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/scripts/build...
File dart/frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/frog/scripts/build...
dart/frog/scripts/buildbot_annotated_steps.py:183: TestStep('browser', mode,
system, 'legium', [], flags)
On 2012/03/22 07:54:03, ngeoffray wrote:
> I guess this run the default suite of tests. Thank you!

I also added leg_only and frog_native.

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/samples/tests/samp...
File dart/samples/tests/samples/samples-leg.status (right):

https://chromiumcodereview.appspot.com/9813012/diff/1/dart/samples/tests/samp...
dart/samples/tests/samples/samples-leg.status:1: # Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/03/22 07:54:03, ngeoffray wrote:
> I think the legium component is in samples.status file, and you need to update
> the expectations for it also. I think it should be a matter of adding legium
in
> this file line 6.

Done.

[ngeoffray, 2012-03-22 10:04:38]

LGTM

https://chromiumcodereview.appspot.com/9813012/diff/7003/dart/frog/frog_optio...
File dart/frog/frog_options.dart (right):

https://chromiumcodereview.appspot.com/9813012/diff/7003/dart/frog/frog_optio...
dart/frog/frog_options.dart:30: bool allowMockCompilation = false;
Good catch :)

https://chromiumcodereview.appspot.com/9813012/diff/7003/dart/samples/tests/s...
File dart/samples/tests/samples/samples-leg.status (right):

https://chromiumcodereview.appspot.com/9813012/diff/7003/dart/samples/tests/s...
dart/samples/tests/samples/samples-leg.status:16: proxy/MintMakerRpcTest: Pass #
This test is failing but the test frame work doesn't detect it.
extra space in frame work.

[ahe, 2012-03-22 10:06:57]

https://chromiumcodereview.appspot.com/9813012/diff/7003/dart/samples/tests/s...
File dart/samples/tests/samples/samples-leg.status (right):

https://chromiumcodereview.appspot.com/9813012/diff/7003/dart/samples/tests/s...
dart/samples/tests/samples/samples-leg.status:16: proxy/MintMakerRpcTest: Pass #
This test is failing but the test frame work doesn't detect it.
On 2012/03/22 10:04:39, ngeoffray wrote:
> extra space in frame work.

Actually, I'll use:

proxy/MintMakerRpcTest: Pass # Issue 2254.