Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 9812007: Add error handling to socket streams (Closed)

Created:
8 years, 9 months ago by Søren Gjesse
Modified:
8 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add error handling to socket streams Change the streams onError callbacks to get an Exception argument on all streams. Added actual error handling to the socket streams. As it is difficult to determine where an error should be reported I decided to call all the registered onError callbacks, that is on the socket itself and on both input and output stream. Did some additional cleanup of the naming of OnError argument in some tests. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5717

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -79 lines) Patch
M runtime/bin/chunked_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_impl.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M runtime/bin/input_stream.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/list_stream_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/output_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket_impl.dart View 6 chunks +41 lines, -24 lines 0 comments Download
M runtime/bin/socket_stream_impl.dart View 1 4 chunks +18 lines, -17 lines 0 comments Download
M runtime/bin/stream_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/string_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/io/FileTest.dart View 11 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
8 years, 9 months ago (2012-03-21 11:40:38 UTC) #1
Mads Ager (google)
LGTM https://chromiumcodereview.appspot.com/9812007/diff/1/runtime/bin/socket_stream_impl.dart File runtime/bin/socket_stream_impl.dart (right): https://chromiumcodereview.appspot.com/9812007/diff/1/runtime/bin/socket_stream_impl.dart#newcode193 runtime/bin/socket_stream_impl.dart:193: Function _clientCloseHandler; Where is the _clientCloseHandler used? It ...
8 years, 9 months ago (2012-03-21 13:18:20 UTC) #2
Søren Gjesse
8 years, 9 months ago (2012-03-21 14:39:46 UTC) #3
https://chromiumcodereview.appspot.com/9812007/diff/1/runtime/bin/socket_stre...
File runtime/bin/socket_stream_impl.dart (right):

https://chromiumcodereview.appspot.com/9812007/diff/1/runtime/bin/socket_stre...
runtime/bin/socket_stream_impl.dart:193: Function _clientCloseHandler;
On 2012/03/21 13:18:20, Mads Ager wrote:
> Where is the _clientCloseHandler used? It doesn't appear to be used in this
> code. If it is used in a super class, we should make it a member there? Or
maybe
> it isn't used?

Thanks for spotting this copy/paste error. Removed.

Powered by Google App Engine
This is Rietveld 408576698