Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 9809007: Make test standalone/src/io/ManyEchoServerTest compile (Closed)

Created:
8 years, 9 months ago by Søren Gjesse
Modified:
8 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make test standalone/src/io/ManyEchoServerTest compile R=ahe@google.com BUG=dart:2266 TEST=tests/standalone/src/io/ManyEchoServerTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/src/io/EchoServerTest.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/src/io/ManyEchoServerTest.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
8 years, 9 months ago (2012-03-26 06:15:01 UTC) #1
ahe
LGTM! Don't forget to remove it from tests/standalone/standalone-leg.status. You can test it like this: ./tools/test.py ...
8 years, 9 months ago (2012-03-26 06:32:16 UTC) #2
Søren Gjesse
8 years, 9 months ago (2012-03-26 06:46:41 UTC) #3
On 2012/03/26 06:32:16, ahe wrote:
> LGTM!
> 
> Don't forget to remove it from tests/standalone/standalone-leg.status.
> 
> You can test it like this:
> 
> ./tools/test.py -mrelease -cdart2js standalone/io/ManyEchoServerTest
> 
> Cheers,
> Peter

Removed from tests/standalone/standalone-leg.status.

Powered by Google App Engine
This is Rietveld 408576698