Issue 9808092: Visit parenthesized expressions in compile-time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9808092: Visit parenthesized expressions in compile-time constants. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Visit parenthesized expressions in compile-time constants. Also switch from unimplemented to error for non-recognized nodes. Committed: https://code.google.com/p/dart/source/detail?r=5799

Patch Set 2 : Add test and update status files. #

Total comments: 2

Patch Set 3 : Address comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
M	frog/leg/compile_time_constants.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
A	tests/language/src/CompileTimeConstantJTest.dart	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9808092/diff/2001/tests/co19/co19-leg.status File tests/co19/co19-leg.status (right): https://chromiumcodereview.appspot.com/9808092/diff/2001/tests/co19/co19-leg.status#newcode146 tests/co19/co19-leg.status:146: Language/10_Expressions/01_Constants_A15_t23: Fail # leg allows x == x ...

8 years, 9 months ago (2012-03-23 23:45:24 UTC) #2

floitsch

https://chromiumcodereview.appspot.com/9808092/diff/2001/tests/co19/co19-leg.status File tests/co19/co19-leg.status (right): https://chromiumcodereview.appspot.com/9808092/diff/2001/tests/co19/co19-leg.status#newcode146 tests/co19/co19-leg.status:146: Language/10_Expressions/01_Constants_A15_t23: Fail # leg allows x == x for ...

8 years, 9 months ago (2012-03-23 23:53:00 UTC) #3

LGTM