Issue 9808019: Make dartdoc compile.

Issue 9808019: Make dartdoc compile. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray, siva

CC:
reviews_dartlang.org, compiler-dev_dartlang.org, mattsh, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make dartdoc compile. Committed: https://code.google.com/p/dart/source/detail?r=5776

Patch Set 2 : Address review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -2 lines)			Patch
M	dart/frog/leg/lib/io.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	dart/frog/leg/lib/mock.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
A	dart/tests/utils/src/DummyCompilerTest.dart	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
M	dart/tests/utils/utils.status	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9808019/diff/1/dart/tests/utils/src/DummyCompilerTest.dart File dart/tests/utils/src/DummyCompilerTest.dart (right): https://chromiumcodereview.appspot.com/9808019/diff/1/dart/tests/utils/src/DummyCompilerTest.dart#newcode3 dart/tests/utils/src/DummyCompilerTest.dart:3: // BSD-style license that can be found in ...

8 years, 9 months ago (2012-03-23 08:08:40 UTC) #2

ahe

https://chromiumcodereview.appspot.com/9808019/diff/1/dart/tests/utils/src/DummyCompilerTest.dart File dart/tests/utils/src/DummyCompilerTest.dart (right): https://chromiumcodereview.appspot.com/9808019/diff/1/dart/tests/utils/src/DummyCompilerTest.dart#newcode3 dart/tests/utils/src/DummyCompilerTest.dart:3: // BSD-style license that can be found in the ...

8 years, 9 months ago (2012-03-23 11:56:40 UTC) #4

siva

8 years, 9 months ago (2012-03-24 02:34:49 UTC) #5

This test assumes that the client source tree would have frog in it, but a
client checked out using standalone.deps not have it and hence this test would
break. Can you modify the test to not have this dependency?

Expand Messages | Collapse Messages