Issue 9802023: Correctly handle constness for list and map literals inside bodies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9802023: Correctly handle constness for list and map literals inside bodies. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Correctly handle constness for list and map literals inside bodies. Also parse const keyword for maps. Closed manually. Committed: https://code.google.com/p/dart/source/detail?r=5944

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -19 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View		5 chunks	+4 lines, -9 lines	0 comments	Download
M	tests/language/language-leg.status	View		5 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

floitsch

I didn't modify the unparser, because the visitLiteralList or visitNewExpression don't look at the const ...

8 years, 9 months ago (2012-03-28 05:19:07 UTC) #1

ahe

LGTM! Could you add a TODO to print the const keyword in unparser? Cheers, Peter

8 years, 9 months ago (2012-03-28 10:16:30 UTC) #2

floitsch

8 years, 9 months ago (2012-03-28 18:17:03 UTC) #4

On 2012/03/28 15:07:37, ngeoffray wrote:
> LGTM!

Added TODOs.