Issue 9773037: Make the temporary OSError allocation method private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9773037: Make the temporary OSError allocation method private. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)

Modified:
8 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the temporary OSError allocation method private. GetField, SetField, Invoke can now be called with a library target and with private names. Using that we can make this temporary utility function private as it should be. Work is under way to support instance creation through the API. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5881

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -14 lines)			Patch
	M	runtime/bin/common.dart	View		1 chunk	+1 line, -9 lines	0 comments	Download
	M	runtime/bin/dartutils.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm, thanks

Expand Messages | Collapse Messages