Issue 9773005: Fix NPE in ArrayBasedScanner

Issue 9773005: Fix NPE in ArrayBasedScanner (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix NPE in ArrayBasedScanner Committed: https://code.google.com/p/dart/source/detail?r=5816

Patch Set 2 : Address review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	dart/frog/leg/scanner/array_based_scanner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	dart/tests/language/src/Issue1578NegativeTest.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src/GarbageNegativeTest.dart File dart/tests/language/src/GarbageNegativeTest.dart (right): https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src/GarbageNegativeTest.dart#newcode5 dart/tests/language/src/GarbageNegativeTest.dart:5: ]~<)$ Please add a comment describing the error this ...

8 years, 9 months ago (2012-03-25 18:24:59 UTC) #3

Lasse Reichstein Nielsen

lgtm https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src/GarbageNegativeTest.dart File dart/tests/language/src/GarbageNegativeTest.dart (right): https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src/GarbageNegativeTest.dart#newcode5 dart/tests/language/src/GarbageNegativeTest.dart:5: ]~<)$ Oh, and since there is an issue ...

8 years, 9 months ago (2012-03-25 18:25:50 UTC) #4

ahe

8 years, 9 months ago (2012-03-26 06:38:36 UTC) #5

Hi Nicolas and Lasse,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src...
File dart/tests/language/src/GarbageNegativeTest.dart (right):

https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src...
dart/tests/language/src/GarbageNegativeTest.dart:5: ]~<)$
On 2012/03/25 18:24:59, Lasse Reichstein Nielsen wrote:
> Please add a comment describing the error this is a regression test for.
> Possibly rename it to something more telling.

Done.

https://chromiumcodereview.appspot.com/9773005/diff/1/dart/tests/language/src...
dart/tests/language/src/GarbageNegativeTest.dart:5: ]~<)$
On 2012/03/25 18:25:50, Lasse Reichstein Nielsen wrote:
> Oh, and since there is an issue number, just put in a link to the issue as the
> comment.

Done.

Expand Messages | Collapse Messages