Issue 9753007: Implement super-send to non-function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9753007: Implement super-send to non-function. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement super-send to non-function. Committed: https://code.google.com/p/dart/source/detail?r=5710

Patch Set 2 : Address review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -13 lines)			Patch
M	dart/frog/leg/ssa/builder.dart	View		1 chunk	+11 lines, -7 lines	0 comments	Download
M	dart/frog/leg/ssa/codegen.dart	View	1	1 chunk	+15 lines, -2 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9753007/diff/1/dart/frog/leg/ssa/codegen.dart File dart/frog/leg/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/9753007/diff/1/dart/frog/leg/ssa/codegen.dart#newcode648 dart/frog/leg/ssa/codegen.dart:648: compiler.registerDynamicGetter(superMethod.name); Please add a comment on why you're ...

8 years, 9 months ago (2012-03-20 15:03:49 UTC) #2

ahe

8 years, 9 months ago (2012-03-21 10:09:55 UTC) #3

Thank you, Nicolas.

https://chromiumcodereview.appspot.com/9753007/diff/1/dart/frog/leg/ssa/codeg...
File dart/frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9753007/diff/1/dart/frog/leg/ssa/codeg...
dart/frog/leg/ssa/codegen.dart:648:
compiler.registerDynamicGetter(superMethod.name);
On 2012/03/20 15:03:49, ngeoffray wrote:
> Please add a comment on why you're registering when it's a getter, but not
when
> it's an invocation. My understand is that it's because the emitter goes
through
> the registered getters to emit a getter, but just looks at the generated code
> when it's a method.

Done.

Expand Messages | Collapse Messages

Issue 9753007: Implement super-send to non-function. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments #

Messages