Issue 9740003: Disable closures in initializers and fail instead of crashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9740003: Disable closures in initializers and fail instead of crashing. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable closures in initializers and fail instead of crashing. Committed: https://code.google.com/p/dart/source/detail?r=5697

Patch Set 1 #

Patch Set 2 : Reupload #

Patch Set 3 : Update status file. #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
M	frog/leg/ssa/builder.dart	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/closure.dart	View		1 chunk	+4 lines, -1 line	1 comment	Download
M	tests/language/language-leg.status	View	1 2	4 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 9 months ago (2012-03-20 21:12:30 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/9740003/diff/4001/frog/leg/ssa/closure...
File frog/leg/ssa/closure.dart (right):

https://chromiumcodereview.appspot.com/9740003/diff/4001/frog/leg/ssa/closure...
frog/leg/ssa/closure.dart:381: if (node.parameters !== null)
node.parameters.accept(this);
Visiting the parameters is also problematic. Long term, I hope we can use the
parameter elements.

Expand Messages | Collapse Messages