Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 9732022: Do not use recursion for depth-first traversal of straight line code. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)
Modified:
8 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not use recursion for depth-first traversal of straight line code. For straight-line sequences of intermediate instructions, use iteration in the depth-first search implementation. R=srdjan@google.com BUG= TEST=vm/CodeIndexTable should pass on x64 Committed: https://code.google.com/p/dart/source/detail?r=5660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -118 lines) Patch
M runtime/vm/intermediate_language.h View 12 chunks +27 lines, -43 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +22 lines, -75 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
8 years, 9 months ago (2012-03-19 21:49:27 UTC) #1
srdjan
8 years, 9 months ago (2012-03-19 21:55:40 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698