Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 9732017: Disable the StringPatternTest. (Closed)

Created:
8 years, 9 months ago by cshapiro
Modified:
8 years, 9 months ago
Reviewers:
ngeoffray, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable the StringPatternTest. The behavior of allMatches in Leg does not yet match that of the VM. Committed: https://code.google.com/p/dart/source/detail?r=5658

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/corelib/corelib-leg.status View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
cshapiro
TBR
8 years, 9 months ago (2012-03-19 21:06:04 UTC) #1
Ivan Posva
LGTM -ip
8 years, 9 months ago (2012-03-19 21:06:35 UTC) #2
ngeoffray
Thanks Carl!
8 years, 9 months ago (2012-03-20 07:35:27 UTC) #3
ahe
8 years, 9 months ago (2012-03-25 01:54:41 UTC) #4
DBC

https://chromiumcodereview.appspot.com/9732017/diff/1/tests/corelib/corelib-l...
File tests/corelib/corelib-leg.status (right):

https://chromiumcodereview.appspot.com/9732017/diff/1/tests/corelib/corelib-l...
tests/corelib/corelib-leg.status:31: StringPatternTest: Fail
It would be great if you could file a bug when you find a problem like this.

Powered by Google App Engine
This is Rietveld 408576698