Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9728008: - Fix use of String operator + in core libraries. (Closed)

Created:
8 years, 9 months ago by Ivan Posva
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Fix use of String operator + in core libraries. Previously reviewed as part of https://chromiumcodereview.appspot.com/9690003 Committed: https://code.google.com/p/dart/source/detail?r=5786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M corelib/src/expect.dart View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
This currently still fails when running with leg. Uploading for reference at the moment. -Ivan
8 years, 9 months ago (2012-03-19 20:19:50 UTC) #1
Lasse Reichstein Nielsen
LGTM.
8 years, 9 months ago (2012-03-20 11:45:42 UTC) #2
Mads Ager (google)
8 years, 9 months ago (2012-03-20 12:50:39 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698