Issue 9726024: Add contexts.

Issue 9726024: Add contexts. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add contexts. Committed: https://code.google.com/p/dart/source/detail?r=5793

Patch Set 8 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -25 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 2 3 4 5 6 7	2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4 5 6 7	12 chunks	+164 lines, -16 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5 6 7	3 chunks	+57 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5 6 7	6 chunks	+67 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

On 2012/03/23 19:19:13, srdjan wrote: Add context handling in the new compiler x64. Every load ...

8 years, 9 months ago (2012-03-23 19:58:07 UTC) #2

regis

LGTM https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_graph_builder.cc#newcode1960 runtime/vm/flow_graph_builder.cc:1960: parsed_function_.function().ToCString(); New line not needed. https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc ...

8 years, 9 months ago (2012-03-23 20:50:25 UTC) #3

srdjan

8 years, 9 months ago (2012-03-23 21:22:19 UTC) #4

https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:1960: parsed_function_.function().ToCString();
On 2012/03/23 20:50:25, regis wrote:
> New line not needed.

Done.

https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_grap...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/9726024/diff/7011/runtime/vm/flow_grap...
runtime/vm/flow_graph_compiler_x64.cc:197: __ movq(CTX, RAX);
On 2012/03/23 20:50:25, regis wrote:
> Why not load directly into CTX?

Done.

Expand Messages | Collapse Messages