Resolve type Dynamic and implement black listing.

Resolve type Dynamic and implement black listing.

Committed: https://code.google.com/p/dart/source/detail?r=5648

[ahe, 2012-03-19 10:51:57]

I still need to polish of a few things, but please take a look now.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:96: static final SourceString DYNAMIC = const
SourceString('Dynamic');
I think these constants are superfluous. I'll try to get rid of most of them.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:198: if (dynamicClass !== null) {
dynamicClass is null while loading the built-in libraries. I'll add a TODO.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1267: error(node.superclass, MessageKind.GENERIC,
['cannot extend']);
Make real error message.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1292: error(link.head, MessageKind.GENERIC, ['cannot
implement']);
Ditto.

[ngeoffray, 2012-03-19 11:48:01]

LGTM

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:220: dynamicClass = new ClassElement(DYNAMIC,
coreLibrary);
Wy don't we have a 'class Dynamic' in the core library? And change the resolver
to set its super to null ?

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:766: bool isInterface() => true;
? What is this for? I believe the original false return was because we did not
support interfaces at that time. Now returning true doesn't look right either.

[ahe, 2012-03-19 15:31:09]

PTAL

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:96: static final SourceString DYNAMIC = const
SourceString('Dynamic');
On 2012/03/19 10:51:57, ahe wrote:
> I think these constants are superfluous. I'll try to get rid of most of them.

Done.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:198: if (dynamicClass !== null) {
On 2012/03/19 10:51:57, ahe wrote:
> dynamicClass is null while loading the built-in libraries. I'll add a TODO.

Done.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:220: dynamicClass = new ClassElement(DYNAMIC,
coreLibrary);
On 2012/03/19 11:48:01, ngeoffray wrote:
> Wy don't we have a 'class Dynamic' in the core library? And change the
resolver
> to set its super to null ?

Done.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:766: bool isInterface() => true;
On 2012/03/19 11:48:01, ngeoffray wrote:
> ? What is this for? I believe the original false return was because we did not
> support interfaces at that time. Now returning true doesn't look right either.

Done.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1267: error(node.superclass, MessageKind.GENERIC,
['cannot extend']);
On 2012/03/19 10:51:57, ahe wrote:
> Make real error message.

Done.

https://chromiumcodereview.appspot.com/9724032/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1292: error(link.head, MessageKind.GENERIC, ['cannot
implement']);
On 2012/03/19 10:51:57, ahe wrote:
> Ditto.

Done.

[ngeoffray, 2012-03-19 15:35:50]

LGTM!