Issue 9724006: Fix typo on run_perf_tests.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9724006: Fix typo on run_perf_tests.py. (Closed)

Created:
8 years, 9 months ago by Emily Fortuna

Modified:
8 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix typo on run_perf_tests.py. Committed: https://code.google.com/p/dart/source/detail?r=5602

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	tools/testing/perf_testing/run_perf_tests.py	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 9 months ago (2012-03-16 22:56:18 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9724006/diff/1/tools/testing/perf_test...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9724006/diff/1/tools/testing/perf_test...
tools/testing/perf_testing/run_perf_tests.py:389: ('Geometric Mean of benchmark
%s performance on %s ' % \
Not sure you need the trailing \ at the end of the line.  You're in an open
paren, so the parser should go onto the next line.

https://chromiumcodereview.appspot.com/9724006/diff/1/tools/testing/perf_test...
tools/testing/perf_testing/run_perf_tests.py:390: (self.platform_type,
utils.GuessOS()), 'Speed (bigger = better)', 16, 5,
Extra whitespace at end of line?

Expand Messages | Collapse Messages