Issue 9722031: Check for null when invoking a native method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9722031: Check for null when invoking a native method. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org, ahe, Lasse Reichstein Nielsen, karlklose, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Check for null when invoking a native method. Committed: https://code.google.com/p/dart/source/detail?r=5626

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -9 lines)			Patch
M	client/tests/client/client-leg.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	frog/leg/native_emitter.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
A	frog/tests/native/src/NativeNullFrogTest.dart	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	samples/tests/samples/samples.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

I'm placing the check very eagerly and knowing it slows down performance, but I need ...

8 years, 9 months ago (2012-03-18 18:28:13 UTC) #1

floitsch

LGTM. https://chromiumcodereview.appspot.com/9722031/diff/1/frog/leg/native_emitter.dart File frog/leg/native_emitter.dart (right): https://chromiumcodereview.appspot.com/9722031/diff/1/frog/leg/native_emitter.dart#newcode159 frog/leg/native_emitter.dart:159: var result = function() { 'result' doesn't seem ...

8 years, 9 months ago (2012-03-18 18:34:21 UTC) #2