Issue 9722012: Get rid of bash for dartdoc and do the whole thing in dart.

Issue 9722012: Get rid of bash for dartdoc and do the whole thing in dart. (Closed)

Created:
8 years, 9 months ago by Bob Nystrom

Modified:
8 years, 9 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get rid of bash for dartdoc and do the whole thing in dart. Committed: https://code.google.com/p/dart/source/detail?r=5659

Patch Set 2 : Respond to review. #

Total comments: 4

Patch Set 3 : Get it working in the SDK. #

Patch Set 4 : Remove cute comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -165 lines)			Patch
D	lib/dartdoc/dartdoc	View		1 chunk	+0 lines, -50 lines	0 comments	Download
M	lib/dartdoc/dartdoc.dart	View	1 2	4 chunks	+49 lines, -51 lines	0 comments	Download
M	lib/dartdoc/utils.dart	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	tools/create_sdk.py	View	1 2	3 chunks	+7 lines, -10 lines	0 comments	Download
D	utils/apidoc/apidoc	View		1 chunk	+0 lines, -39 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View	1 2 3	4 chunks	+28 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

https://chromiumcodereview.appspot.com/9722012/diff/1/lib/dartdoc/dartdoc.dart File lib/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9722012/diff/1/lib/dartdoc/dartdoc.dart#newcode9 lib/dartdoc/dartdoc.dart:9: * $ dart dartdoc.dart foo.dart Shouldn't this be indented ...

8 years, 9 months ago (2012-03-17 00:39:31 UTC) #2

Bob Nystrom

Thanks! https://chromiumcodereview.appspot.com/9722012/diff/1/lib/dartdoc/dartdoc.dart File lib/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9722012/diff/1/lib/dartdoc/dartdoc.dart#newcode9 lib/dartdoc/dartdoc.dart:9: * $ dart dartdoc.dart foo.dart On 2012/03/17 00:39:31, ...

8 years, 9 months ago (2012-03-17 01:14:19 UTC) #3

ahe

DBC https://chromiumcodereview.appspot.com/9722012/diff/7/lib/dartdoc/dartdoc.dart File lib/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9722012/diff/7/lib/dartdoc/dartdoc.dart#newcode182 lib/dartdoc/dartdoc.dart:182: print(error); exit(1); https://chromiumcodereview.appspot.com/9722012/diff/7/utils/apidoc/apidoc.dart File utils/apidoc/apidoc.dart (right): https://chromiumcodereview.appspot.com/9722012/diff/7/utils/apidoc/apidoc.dart#newcode15 utils/apidoc/apidoc.dart:15: ...

8 years, 9 months ago (2012-03-17 20:19:31 UTC) #4

Bob Nystrom

8 years, 9 months ago (2012-03-19 21:09:34 UTC) #6

Thanks!

https://chromiumcodereview.appspot.com/9722012/diff/7/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9722012/diff/7/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:182: print(error);
On 2012/03/17 20:19:31, ahe wrote:
> exit(1);

Leaving this alone for now. I'm not sure if I do want dartdoc to abort in this
case.

https://chromiumcodereview.appspot.com/9722012/diff/7/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9722012/diff/7/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:15: * Pretty simple. :)
On 2012/03/17 20:19:31, ahe wrote:
> Remove cute comment. It's just annoying when it doesn't work :-)

Done.

Expand Messages | Collapse Messages