Issue 9720033: More GYP tweaking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9720033: More GYP tweaking. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
Emily Fortuna, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

More GYP tweaking. Committed: https://code.google.com/p/dart/source/detail?r=5634

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	dart/utils/compiler/compiler.gyp	View		1 chunk	+20 lines, -20 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9720033/diff/1/dart/utils/compiler/compiler.gyp File dart/utils/compiler/compiler.gyp (right): https://chromiumcodereview.appspot.com/9720033/diff/1/dart/utils/compiler/compiler.gyp#newcode26 dart/utils/compiler/compiler.gyp:26: 'action': [ extra indentation

8 years, 9 months ago (2012-03-19 08:17:49 UTC) #2

lgtm, with Nicolas's comment.

Expand Messages | Collapse Messages