Issue 9720030: Compile initializers in right order.

Issue 9720030: Compile initializers in right order. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Compile initializers in right order. Committed: https://code.google.com/p/dart/source/detail?r=5624

Patch Set 2 : Update status files. #

Total comments: 9

Patch Set 3 : Address comments. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -75 lines)			Patch
M	frog/leg/ssa/builder.dart	View	1 2	2 chunks	+72 lines, -67 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	3 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9720030/diff/1001/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9720030/diff/1001/frog/leg/ssa/builder.dart#newcode775 frog/leg/ssa/builder.dart:775: * with sub constructors having a lower index ...

8 years, 9 months ago (2012-03-18 14:00:44 UTC) #3

floitsch

https://chromiumcodereview.appspot.com/9720030/diff/1001/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9720030/diff/1001/frog/leg/ssa/builder.dart#newcode775 frog/leg/ssa/builder.dart:775: * with sub constructors having a lower index then ...

8 years, 9 months ago (2012-03-18 15:36:09 UTC) #4

ngeoffray

8 years, 9 months ago (2012-03-18 15:44:53 UTC) #5

https://chromiumcodereview.appspot.com/9720030/diff/1001/frog/leg/ssa/builder...
File frog/leg/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/9720030/diff/1001/frog/leg/ssa/builder...
frog/leg/ssa/builder.dart:827: // No super initializer found. Try to find the
default constructor if
On 2012/03/18 15:36:10, floitsch wrote:
> On 2012/03/18 14:00:44, ngeoffray wrote:
> > default -> super
> I think 'default' is correct here. We are trying to find the unnamed
constructor
> without arguments.

Right. 'default' bothers me because it makes me think it's the synthesized one.
Maybe that's just me.

Expand Messages | Collapse Messages