Issue 9720024: If there were breaks in a loop, we must not restore the saved localsHandler before entering the loo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9720024: If there were breaks in a loop, we must not restore the saved localsHandler before entering the loo… (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org, karlklose, ahe, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

If there were breaks in a loop, we must not restore the saved localsHandler before entering the loop body. Committed: https://code.google.com/p/dart/source/detail?r=5619

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
M	frog/leg/ssa/builder.dart	View	1	5 chunks	+8 lines, -7 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/corelib/corelib-leg.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. I think it is more correct to not use the (current) localsHandler when exiting ...

8 years, 9 months ago (2012-03-17 22:25:00 UTC) #2

ngeoffray

8 years, 9 months ago (2012-03-18 12:03:45 UTC) #4

Thanks Lasse and Florian.

https://chromiumcodereview.appspot.com/9720024/diff/1/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/9720024/diff/1/frog/leg/ssa/builder.da...
frog/leg/ssa/builder.dart:1055: breakLocals.add(localsHandler);
On 2012/03/17 22:25:00, floitsch wrote:
> add(savedLocals);

Thanks for the suggestion. Done.

https://chromiumcodereview.appspot.com/9720024/diff/1/frog/leg/ssa/builder.da...
frog/leg/ssa/builder.dart:1172: endLoop(loopEntryBlock, conditionBlock,
breakHandler, null);
On 2012/03/17 22:25:00, floitsch wrote:
> localsHandler

Done.

Expand Messages | Collapse Messages