Issue 9719019: Launch Leg independently of Frog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9719019: Launch Leg independently of Frog. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Launch Leg independently of Frog. Committed: https://code.google.com/p/dart/source/detail?r=5630

Patch Set 2 : Address own comment #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -226 lines)			Patch
M	dart/dart.gyp	View		3 chunks	+7 lines, -15 lines	0 comments	Download
A	dart/frog/leg/colors.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	dart/frog/leg/compiler.dart	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	dart/frog/leg/leg.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/frog/presubmit.py	View		1 chunk	+14 lines, -11 lines	0 comments	Download
M	dart/frog/scripts/buildbot_annotated_steps.py	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	dart/utils/compiler/build_helper.dart	View	1	1 chunk	+45 lines, -57 lines	0 comments	Download
M	dart/utils/compiler/dart2js.dart	View		3 chunks	+81 lines, -23 lines	0 comments	Download
M	dart/utils/compiler/source_file.dart	View		4 chunks	+13 lines, -101 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/9719019/diff/11/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/9719019/diff/11/dart/utils/compiler/build_helper.dart#newcode29 dart/utils/compiler/build_helper.dart:29: stream.writeStringSync(chunk); Doh! Remove second line.

8 years, 9 months ago (2012-03-17 18:56:13 UTC) #2