Issue 9719017: Fixed a few typos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9719017: Fixed a few typos. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
polux, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed a few typos. Committed: https://code.google.com/p/dart/source/detail?r=5614

Patch Set 2 : Include test #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -4 lines)			Patch
	M	dart/frog/leg/resolver.dart	View		3 chunks	+5 lines, -4 lines	0 comments	Download
	A	dart/tests/language/src/ThisTest.dart	View	1	1 chunk	+23 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Still LGTM, thanks for the test. https://chromiumcodereview.appspot.com/9719017/diff/1002/dart/tests/language/src/ThisTest.dart File dart/tests/language/src/ThisTest.dart (right): https://chromiumcodereview.appspot.com/9719017/diff/1002/dart/tests/language/src/ThisTest.dart#newcode9 dart/tests/language/src/ThisTest.dart:9: testMe() { How ...

8 years, 9 months ago (2012-03-17 16:22:42 UTC) #4

ahe

8 years, 9 months ago (2012-03-17 16:32:57 UTC) #5

Filed Issue 2210 to track your suggestion for extended testing.

https://chromiumcodereview.appspot.com/9719017/diff/1002/dart/tests/language/...
File dart/tests/language/src/ThisTest.dart (right):

https://chromiumcodereview.appspot.com/9719017/diff/1002/dart/tests/language/...
dart/tests/language/src/ThisTest.dart:9: testMe() {
On 2012/03/17 16:22:42, ngeoffray wrote:
> How about this() ?

I'll have to check up on the specification. I'm pretty sure "this()" should work
and should be part of CallOperatorTest.dart. It isn't, so I'll file a bug about
that.

Expand Messages | Collapse Messages

Issue 9719017: Fixed a few typos. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Include test #

Messages