Issue 9717042: Don't build dart2js on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9717042: Don't build dart2js on Windows. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
Emily Fortuna, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't build dart2js on Windows. Committed: https://code.google.com/p/dart/source/detail?r=5633

Patch Set 1 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	dart/utils/compiler/compiler.gyp	View		2 chunks	+12 lines, -12 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm, with comment. thanks! https://chromiumcodereview.appspot.com/9717042/diff/2001/dart/utils/compiler/compiler.gyp File dart/utils/compiler/compiler.gyp (right): https://chromiumcodereview.appspot.com/9717042/diff/2001/dart/utils/compiler/compiler.gyp#newcode25 dart/utils/compiler/compiler.gyp:25: ['OS!="win"', { Can you add ...

8 years, 9 months ago (2012-03-22 18:04:38 UTC) #3

ahe

8 years, 9 months ago (2012-03-22 18:23:33 UTC) #4

Thank you, Emily.

https://chromiumcodereview.appspot.com/9717042/diff/2001/dart/utils/compiler/...
File dart/utils/compiler/compiler.gyp (right):

https://chromiumcodereview.appspot.com/9717042/diff/2001/dart/utils/compiler/...
dart/utils/compiler/compiler.gyp:25: ['OS!="win"', {
On 2012/03/22 18:04:38, Emily Fortuna wrote:
> Can you add a TODO(ahe) to remind us to enable building on this in the future?

I have CL in progress for this. Søren has helped me but we got interrupted. I'm
pretty sure I know what needs to be done, and I will do it :-)

Expand Messages | Collapse Messages