Issue 9717035: Handle compile-time constants to interfaces.

Issue 9717035: Handle compile-time constants to interfaces. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle compile-time constants to interfaces. Committed: https://code.google.com/p/dart/source/detail?r=5629

Patch Set 2 : Address comments. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
M	frog/leg/compile_time_constants.dart	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	tests/language/language-leg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/src/CompileTimeConstantFTest.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/src/CompileTimeConstantGTest.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/CompileTimeConstantHTest.dart	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/utils/utils.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9717035/diff/1/frog/leg/compile_time_constants.dart File frog/leg/compile_time_constants.dart (right): https://chromiumcodereview.appspot.com/9717035/diff/1/frog/leg/compile_time_constants.dart#newcode981 frog/leg/compile_time_constants.dart:981: // TODO(floitsch): get the type from somewhere. Why ...

8 years, 9 months ago (2012-03-18 13:56:04 UTC) #2

floitsch

8 years, 9 months ago (2012-03-18 18:44:14 UTC) #3

https://chromiumcodereview.appspot.com/9717035/diff/1/frog/leg/compile_time_c...
File frog/leg/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9717035/diff/1/frog/leg/compile_time_c...
frog/leg/compile_time_constants.dart:981: // TODO(floitsch): get the type from
somewhere.
On 2012/03/18 13:56:04, ngeoffray wrote:
> Why is classElement.computeType(compiler) not sufficient?

It doesn't take generic types into account. But better than creating a new
simpletype myself.
Updated and changed comment.

https://chromiumcodereview.appspot.com/9717035/diff/1/frog/leg/compile_time_c...
frog/leg/compile_time_constants.dart:984:
compiler.resolver.resolveMethodElement(constructor);
On 2012/03/18 13:56:04, ngeoffray wrote:
> You could avoid calling resolveMethodElement twice if constructor ===
> constructor.defaultImplementation.

Done.

https://chromiumcodereview.appspot.com/9717035/diff/1/tests/language/src/Comp...
File tests/language/src/CompileTimeConstantHTest.dart (right):

https://chromiumcodereview.appspot.com/9717035/diff/1/tests/language/src/Comp...
tests/language/src/CompileTimeConstantHTest.dart:4: // Dart test program for
testing setting/getting of instance fields.
On 2012/03/18 13:56:04, ngeoffray wrote:
> Please update description.

Removed comment.
Done.

Expand Messages | Collapse Messages