Issue 9706086: Clean-up CodeGenState: remove unused loop_level and move context_level to CodeGenerator (and add it…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9706086: Clean-up CodeGenState: remove unused loop_level and move context_level to CodeGenerator (and add it… (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Clean-up CodeGenState: remove unused loop_level and move context_level to CodeGenerator (and add it to FlowGraphBuilder). Committed: https://code.google.com/p/dart/source/detail?r=5571

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -80 lines)			Patch
M	runtime/vm/code_generator_ia32.h	View	1	4 chunks	+6 lines, -19 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	13 chunks	+18 lines, -19 lines	0 comments	Download
M	runtime/vm/code_generator_x64.h	View	1	4 chunks	+6 lines, -19 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1	13 chunks	+18 lines, -19 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+14 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM I wonder if we should remove CodeGeneratorState alltogether, and save/restore the remaining two fields ...

8 years, 9 months ago (2012-03-15 23:39:07 UTC) #2

srdjan

8 years, 9 months ago (2012-03-15 23:45:40 UTC) #3

Yes, I guess we could remove the CodeGenState. Next CL.

https://chromiumcodereview.appspot.com/9706086/diff/9/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9706086/diff/9/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder.cc:1271: // Allocate context computation
On 2012/03/15 23:39:07, regis wrote:
> period

Done.

Expand Messages | Collapse Messages