Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9706084: Add conditional feature to templates. (Closed)

Created:
8 years, 9 months ago by sra1
Modified:
8 years, 9 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add conditional feature to templates. Also, fix some scripts/all_tests.py errors. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5553

Patch Set 1 #

Patch Set 2 : missing import #

Total comments: 4

Patch Set 3 : CR fixes #

Patch Set 4 : merge #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -64 lines) Patch
M client/dom/scripts/all_tests.py View 1 chunk +1 line, -0 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 4 chunks +5 lines, -40 lines 0 comments Download
M client/dom/scripts/dartgenerator_test.py View 3 chunks +8 lines, -6 lines 0 comments Download
M client/dom/scripts/idlrenderer.py View 1 2 10 chunks +25 lines, -15 lines 0 comments Download
M client/dom/scripts/idlrenderer_test.py View 2 chunks +12 lines, -3 lines 0 comments Download
A client/dom/scripts/templateloader.py View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
A client/dom/scripts/templateloader_test.py View 1 chunk +125 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
8 years, 9 months ago (2012-03-15 23:19:33 UTC) #1
Jacob
https://chromiumcodereview.appspot.com/9706084/diff/2001/client/dom/scripts/idlrenderer.py File client/dom/scripts/idlrenderer.py (right): https://chromiumcodereview.appspot.com/9706084/diff/2001/client/dom/scripts/idlrenderer.py#newcode27 client/dom/scripts/idlrenderer.py:27: """Writes the given node and adds a space there ...
8 years, 9 months ago (2012-03-15 23:34:47 UTC) #2
sra1
https://chromiumcodereview.appspot.com/9706084/diff/2001/client/dom/scripts/idlrenderer.py File client/dom/scripts/idlrenderer.py (right): https://chromiumcodereview.appspot.com/9706084/diff/2001/client/dom/scripts/idlrenderer.py#newcode27 client/dom/scripts/idlrenderer.py:27: """Writes the given node and adds a space there ...
8 years, 9 months ago (2012-03-15 23:43:35 UTC) #3
Jacob
8 years, 9 months ago (2012-03-15 23:44:10 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698