Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 9706077: Don't generate docs for private types. Cuts doc generation time in half. (Closed)

Created:
8 years, 9 months ago by Bob Nystrom
Modified:
8 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't generate docs for private types. Cuts doc generation time in half. Committed: https://code.google.com/p/dart/source/detail?r=5579

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M lib/dartdoc/dartdoc.dart View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
8 years, 9 months ago (2012-03-15 20:48:50 UTC) #1
nweiz
https://chromiumcodereview.appspot.com/9706077/diff/1/lib/dartdoc/dartdoc.dart File lib/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9706077/diff/1/lib/dartdoc/dartdoc.dart#newcode536 lib/dartdoc/dartdoc.dart:536: if (type.name.startsWith('_')) continue; I personally like using continue here, ...
8 years, 9 months ago (2012-03-15 21:04:42 UTC) #2
Bob Nystrom
https://chromiumcodereview.appspot.com/9706077/diff/1/lib/dartdoc/dartdoc.dart File lib/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9706077/diff/1/lib/dartdoc/dartdoc.dart#newcode536 lib/dartdoc/dartdoc.dart:536: if (type.name.startsWith('_')) continue; On 2012/03/15 21:04:43, nweiz wrote: > ...
8 years, 9 months ago (2012-03-15 22:14:28 UTC) #3
nweiz
8 years, 9 months ago (2012-03-15 23:11:03 UTC) #4
On 2012/03/15 22:14:28, Bob Nystrom wrote:
> https://chromiumcodereview.appspot.com/9706077/diff/1/lib/dartdoc/dartdoc.dart
> File lib/dartdoc/dartdoc.dart (right):
> 
>
https://chromiumcodereview.appspot.com/9706077/diff/1/lib/dartdoc/dartdoc.dar...
> lib/dartdoc/dartdoc.dart:536: if (type.name.startsWith('_')) continue;
> On 2012/03/15 21:04:43, nweiz wrote:
> > I personally like using continue here, but isn't it contrary to the
preferred
> > style?
> 
> I don't think so. I know some people aren't a fan of continue, but I'm not
aware
> of any prescription against using it.

In that case, lgtm!

Powered by Google App Engine
This is Rietveld 408576698