Issue 9706054: Fix wrong assumptions I had on the isolate library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9706054: Fix wrong assumptions I had on the isolate library. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, karlklose, ahe, Lasse Reichstein Nielsen, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix wrong assumptions I had on the isolate library. Committed: https://code.google.com/p/dart/source/detail?r=5517

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -9 lines)			Patch
M	frog/leg/emitter.dart	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	frog/leg/ssa/builder.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/isolate/isolate-leg.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://chromiumcodereview.appspot.com/9706054/diff/1/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9706054/diff/1/frog/leg/ssa/builder.dart#newcode1727 frog/leg/ssa/builder.dart:1727: push(new HForeign(new DartString.literal('!!#.$name'), In case we don't propagate types, ...

8 years, 9 months ago (2012-03-15 12:15:38 UTC) #1

LGTM.

Expand Messages | Collapse Messages