Issue 9706033: Fix failing test on windows. I was accessing a stat too early.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9706033: Fix failing test on windows. I was accessing a stat too early. (Closed)

Created:
8 years, 9 months ago by turnidge

Modified:
8 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix failing test on windows. I was accessing a stat too early. Committed: https://code.google.com/p/dart/source/detail?r=5487

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	runtime/vm/thread_pool_test.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

turnidge

8 years, 9 months ago (2012-03-14 21:18:55 UTC) #1

I was trying to access workers_idle() before the one worker had had a chance to
add itself back to the idle queue.  Remove workers_idle() and workers_running()
checks to avoid race in test.

TBR=iposva

Expand Messages | Collapse Messages