Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 9706032: Add Throw and ReThrow nodes. Rethrow not yet tested (bailout with untested), since it needs the try… (Closed)

Created:
8 years, 9 months ago by srdjan
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add Throw and ReThrow nodes. Rethrow not yet tested (bailout with untested), since it needs the try/catch implementation. Discuss if Throw/ReThrow shoudl be computations or instructions. We have one case in parser where throw is added into the expression tree. I suggest introducing an EndInstr that has no successor and use it for throw and return. (TODO: Discuss and chnage if necessary). Currently we generate code even after the throw. Committed: https://code.google.com/p/dart/source/detail?r=5490

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -1 line) Patch
M runtime/vm/flow_graph_builder.cc View 2 chunks +33 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +59 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 9 months ago (2012-03-14 21:05:13 UTC) #1
regis
8 years, 9 months ago (2012-03-14 21:24:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698