Allow specifying output directory for dartdoc and apidoc.

Allow specifying output directory for dartdoc and apidoc.

Committed: https://code.google.com/p/dart/source/detail?r=5578

[nweiz, 2012-03-15 23:45:47]

lgtm

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:59: var outputDir;
These should have types declared, since they're not initialized here.

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:79: outputDir = arg.substring('--out='.length);
Is there a bug filed against Options to support options with arguments?

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:107: // TODO(rnystrom): Use platform-specific path
separator.
Won't Windows understand "/", even if it doesn't prefer it?

[mattsh, 2012-03-15 23:52:55]

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:83: }
missing break

[Bob Nystrom, 2012-03-15 23:58:23]

Thanks!

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:59: var outputDir;
On 2012/03/15 23:45:48, nweiz wrote:
> These should have types declared, since they're not initialized here.

Done.

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:79: outputDir = arg.substring('--out='.length);
On 2012/03/15 23:45:48, nweiz wrote:
> Is there a bug filed against Options to support options with arguments?

No, but I don't really think arg parsing should be built into the core options
class. If it was me, I'd have a separate args library to do that.

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:83: }
On 2012/03/15 23:52:55, mattsh wrote:
> missing break

Done.

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:107: // TODO(rnystrom): Use platform-specific path
separator.
On 2012/03/15 23:45:48, nweiz wrote:
> Won't Windows understand "/", even if it doesn't prefer it?

Not sure. The Platform class in Dart does have a path separator accessor, so it
seems like we should use it. I just don't want to refactor dartdoc right now to
do that.

[nweiz, 2012-03-16 00:15:49]

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:79: outputDir = arg.substring('--out='.length);
On 2012/03/15 23:58:23, Bob Nystrom wrote:
> On 2012/03/15 23:45:48, nweiz wrote:
> > Is there a bug filed against Options to support options with arguments?
> 
> No, but I don't really think arg parsing should be built into the core options
> class. If it was me, I'd have a separate args library to do that.

What's the Options class for if not arg parsing?

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:107: // TODO(rnystrom): Use platform-specific path
separator.
On 2012/03/15 23:58:23, Bob Nystrom wrote:
> On 2012/03/15 23:45:48, nweiz wrote:
> > Won't Windows understand "/", even if it doesn't prefer it?
> 
> Not sure. The Platform class in Dart does have a path separator accessor, so
it
> seems like we should use it. I just don't want to refactor dartdoc right now
to
> do that.

If we don't have to use the separator constant for this to work, we shouldn't.
Using "/" is much more readable.

[Bob Nystrom, 2012-03-16 00:22:36]

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:79: outputDir = arg.substring('--out='.length);
On 2012/03/16 00:15:49, nweiz wrote:
> On 2012/03/15 23:58:23, Bob Nystrom wrote:
> > On 2012/03/15 23:45:48, nweiz wrote:
> > > Is there a bug filed against Options to support options with arguments?
> > 
> > No, but I don't really think arg parsing should be built into the core
options
> > class. If it was me, I'd have a separate args library to do that.
> 
> What's the Options class for if not arg parsing?

It's for being able to access them at all. I would like nice arg parsing too,
but I'd like that in a separate lib on top of options so that when a better lib
comes along, I'm not stuck with the old one.

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:107: // TODO(rnystrom): Use platform-specific path
separator.
On 2012/03/16 00:15:49, nweiz wrote:
> On 2012/03/15 23:58:23, Bob Nystrom wrote:
> > On 2012/03/15 23:45:48, nweiz wrote:
> > > Won't Windows understand "/", even if it doesn't prefer it?
> > 
> > Not sure. The Platform class in Dart does have a path separator accessor, so
> it
> > seems like we should use it. I just don't want to refactor dartdoc right now
> to
> > do that.
> 
> If we don't have to use the separator constant for this to work, we shouldn't.
> Using "/" is much more readable.

Works for me. I won't plan to change this until I see an actual bug report that
it doesn't work on Windows.

[nweiz, 2012-03-16 18:25:51]

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9705078/diff/1/lib/dartdoc/dartdoc.dar...
lib/dartdoc/dartdoc.dart:79: outputDir = arg.substring('--out='.length);
On 2012/03/16 00:22:37, Bob Nystrom wrote:
> On 2012/03/16 00:15:49, nweiz wrote:
> > On 2012/03/15 23:58:23, Bob Nystrom wrote:
> > > On 2012/03/15 23:45:48, nweiz wrote:
> > > > Is there a bug filed against Options to support options with arguments?
> > > 
> > > No, but I don't really think arg parsing should be built into the core
> options
> > > class. If it was me, I'd have a separate args library to do that.
> > 
> > What's the Options class for if not arg parsing?
> 
> It's for being able to access them at all. I would like nice arg parsing too,
> but I'd like that in a separate lib on top of options so that when a better
lib
> comes along, I'm not stuck with the old one.

Maybe this is more of an API design issue, but the name "Options" seems to
indicate that it provides some, you know, options handling. Especially since
you're instantiating an object.

Anyway, this is pretty off-topic for this CL.