Issue 9705041: Fix 2172: report 'int' instead of Smi, Mint and Bigint when throwing TypeError.

Issue 9705041: Fix 2172: report 'int' instead of Smi, Mint and Bigint when throwing TypeError. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 2172: report 'int' instead of Smi, Mint and Bigint when throwing TypeError. Committed: https://code.google.com/p/dart/source/detail?r=5525

Patch Set 5 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3	5 chunks	+15 lines, -8 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/src/TypeVMTest.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM, but you missed a few locations. https://chromiumcodereview.appspot.com/9705041/diff/3001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/9705041/diff/3001/runtime/vm/code_generator.cc#newcode512 runtime/vm/code_generator.cc:512: const String& ...

8 years, 9 months ago (2012-03-15 00:56:38 UTC) #2

srdjan

8 years, 9 months ago (2012-03-15 01:10:12 UTC) #3

https://chromiumcodereview.appspot.com/9705041/diff/3001/runtime/vm/code_gene...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/9705041/diff/3001/runtime/vm/code_gene...
runtime/vm/code_generator.cc:512: const String& src_type_name =
String::Handle(src_type.Name());
On 2012/03/15 00:56:39, regis wrote:
> You should map the name here as well.

Done.

https://chromiumcodereview.appspot.com/9705041/diff/3001/runtime/vm/code_gene...
runtime/vm/code_generator.cc:538:
String::Handle(Type::Handle(src_value.GetType()).Name());
On 2012/03/15 00:56:39, regis wrote:
> And here.

Done.

https://chromiumcodereview.appspot.com/9705041/diff/3001/runtime/vm/code_gene...
runtime/vm/code_generator.cc:585:
String::Handle(Type::Handle(elem.GetType()).Name());
On 2012/03/15 00:56:39, regis wrote:
> And here, although this function is not used anymore.

Done.

Expand Messages | Collapse Messages