Issue 9705025: const constructors with optional arguments.

Issue 9705025: const constructors with optional arguments. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

const constructors with optional arguments. Committed: https://code.google.com/p/dart/source/detail?r=5529

Patch Set 2 : Address comments. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -43 lines)			Patch
M	frog/leg/compile_time_constants.dart	View	1	3 chunks	+14 lines, -29 lines	0 comments	Download
M	frog/leg/resolver.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	frog/leg/universe.dart	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	frog/leg/warnings.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/CompileTimeConstantETest.dart	View		1 chunk	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9705025/diff/1/frog/leg/compile_time_constants.dart File frog/leg/compile_time_constants.dart (right): https://chromiumcodereview.appspot.com/9705025/diff/1/frog/leg/compile_time_constants.dart#newcode915 frog/leg/compile_time_constants.dart:915: Function visitConstant = constantHandler.compileVariable; Because this class is ...

8 years, 9 months ago (2012-03-15 10:24:57 UTC) #2

floitsch

8 years, 9 months ago (2012-03-15 14:30:47 UTC) #3

https://chromiumcodereview.appspot.com/9705025/diff/1/frog/leg/compile_time_c...
File frog/leg/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9705025/diff/1/frog/leg/compile_time_c...
frog/leg/compile_time_constants.dart:915: Function visitConstant =
constantHandler.compileVariable;
On 2012/03/15 10:24:58, ngeoffray wrote:
> Because this class is a visitor, I'd prefer avoiding the name 'visit'. Also,
you
> could drop evaluateConstant, visitArgument and visitConstant and pass the
> functions directly to addSendArgumentsToList.

removed evaluateConstant (old dead code).
renamed visit{Argument|Constant} to compile{Argument|Constant} and changed the
name of the parameters in addSendArgumentsToList.

Expand Messages | Collapse Messages