Issue 9705004: Do not chain the current context on entry in non-closure functions, but

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705004: Do not chain the current context on entry in non-closure functions, but (Closed)

Created:
8 years, 9 months ago by regis

Modified:
8 years, 9 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not chain the current context on entry in non-closure functions, but save and restore it on the stack instead, and chain a null context (issue 1613). Committed: https://code.google.com/p/dart/source/detail?r=5446

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -7 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	4 chunks	+38 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	4 chunks	+38 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

regis

A solution involving a new hidden local variable instead of saving/restoring directly on/from the stack ...

8 years, 9 months ago (2012-03-13 23:35:40 UTC) #1

srdjan

8 years, 9 months ago (2012-03-13 23:42:34 UTC) #2

LGTM
(It seems that the new compiler has not implemented enough of contexts to
require a change as well)

Expand Messages | Collapse Messages