Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 9704098: Add build rules for dart2js. (Closed)

Created:
8 years, 9 months ago by ahe
Modified:
8 years, 9 months ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org, compiler-dev_dartlang.org
Visibility:
Public.

Description

Add build rules for dart2js. Committed: https://code.google.com/p/dart/source/detail?r=5613

Patch Set 1 : #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -2 lines) Patch
M dart/dart.gyp View 2 chunks +10 lines, -2 lines 0 comments Download
A dart/utils/compiler/build_helper.dart View 1 chunk +81 lines, -0 lines 7 comments Download
A dart/utils/compiler/compiler.gyp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 9 months ago (2012-03-16 17:06:27 UTC) #1
ngeoffray
LGTM https://chromiumcodereview.appspot.com/9704098/diff/2001/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/9704098/diff/2001/dart/utils/compiler/build_helper.dart#newcode16 dart/utils/compiler/build_helper.dart:16: String launcherScript = """ Maybe move this variable ...
8 years, 9 months ago (2012-03-17 16:00:56 UTC) #2
ahe
Thank you, Nicolas. https://chromiumcodereview.appspot.com/9704098/diff/2001/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/9704098/diff/2001/dart/utils/compiler/build_helper.dart#newcode16 dart/utils/compiler/build_helper.dart:16: String launcherScript = """ On 2012/03/17 ...
8 years, 9 months ago (2012-03-17 16:16:46 UTC) #3
ahe
8 years, 9 months ago (2012-03-17 16:21:37 UTC) #4
https://chromiumcodereview.appspot.com/9704098/diff/2001/dart/utils/compiler/...
File dart/utils/compiler/build_helper.dart (right):

https://chromiumcodereview.appspot.com/9704098/diff/2001/dart/utils/compiler/...
dart/utils/compiler/build_helper.dart:79: // TODO(ahe): Make scripts executable.
On 2012/03/17 16:16:46, ahe wrote:
> On 2012/03/17 16:00:56, ngeoffray wrote:
> > Why not doing it now? Are we missing the API?
> 
> I think there is API for running "chmod +x", but I'll deal with this later;
I'm
> doing this in steps.

Adding a little more insight into my thinking: running "chmod +x" will not work
on Windows, but I'm hooking this up to the build system now. So I'm being
conservative to avoid breaking Windows builds.

Powered by Google App Engine
This is Rietveld 408576698