Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 9704083: Use dart:io directory deletion instead of starting a process. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use dart:io directory deletion instead of starting a process. Bill, Eric, is this path ever hit at this point. It seems to me that it was only hit when dartc produced output to be run in a browser. If that is the case, could one of you remove all the code that has to do with the temporary directory handling as a follow-up change? R=zundel@google.com,whesse@google.com BUG=1211 TEST= Committed: https://code.google.com/p/dart/source/detail?r=5748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +5 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zundel
dartc may still creates a directory for incremental build and some optional build output. If ...
8 years, 9 months ago (2012-03-18 16:02:42 UTC) #1
Mads Ager (google)
Bill, could you have a look please?
8 years, 9 months ago (2012-03-21 14:32:10 UTC) #2
zundel
On 2012/03/21 14:32:10, Mads Ager wrote: > Bill, could you have a look please? I ...
8 years, 9 months ago (2012-03-21 14:34:17 UTC) #3
Mads Ager (google)
On 2012/03/21 14:34:17, zundel wrote: > On 2012/03/21 14:32:10, Mads Ager wrote: > > Bill, ...
8 years, 9 months ago (2012-03-21 14:37:41 UTC) #4
Søren Gjesse
8 years, 9 months ago (2012-03-22 08:21:17 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698