Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 9704081: SDK: correct the type of the argument to 'print' to 'Object' for runtime version of core. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
Reviewers:
kasperl, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

SDK: correct the type of the argument to 'print' to 'Object' for runtime version of core. This avoids the needless type warnings that you get with something like: print(new Map()) R=danrubel@google.com,kasperl@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 9 months ago (2012-03-16 09:38:40 UTC) #1
kasperl
LGTM!
8 years, 9 months ago (2012-03-16 09:42:02 UTC) #2
danrubel
8 years, 9 months ago (2012-03-16 14:15:30 UTC) #3
Good fix! Thanks!

Powered by Google App Engine
This is Rietveld 408576698