Issue 9704067: Move print from builtin to core in runtime SDK sources only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704067: Move print from builtin to core in runtime SDK sources only (Closed)

Created:
8 years, 9 months ago by danrubel

Modified:
8 years, 9 months ago

Reviewers:
devoncarew, dgrove

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move print from builtin to core in runtime SDK sources only Committed: https://code.google.com/p/dart/source/detail?r=5547

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	tools/create_sdk.py	View		2 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danrubel

This does not move the print function in the VM itself... that is more involved. ...

8 years, 9 months ago (2012-03-15 21:49:13 UTC) #1

devoncarew

8 years, 9 months ago (2012-03-15 22:06:26 UTC) #2

lgtm

It'll be great to have the print() error fixed!

https://chromiumcodereview.appspot.com/9704067/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/9704067/diff/1/tools/create_sdk.py#new...
tools/create_sdk.py:174: ])
If I understand the chronology correctly, dart:builtin was replaced when dart:io
was created. We should talk next week about removing it from the SDK.

Expand Messages | Collapse Messages